Good first issue for phi kernel output definition #51292

From00 · 2023-03-07T07:43:53Z

问题描述 Please describe your issue

大家好，近期我们在Paddle框架中发现一些phi算子库中的算子，在kernel注册时未注册输出参数的数据类型（DataType）信息，导致静态图模式下执行器全静态选kernel出错。我们一共收集了68个存在问题的算子，欢迎大家提交PR来一起修复这些问题。

为了修复这些问题，你需要做的是：

阅读《开发C++算子》文档，学习C++算子开发流程。本次任务涉及对已有算子的改动，不需要完整地实现一个新算子，但了解新增算子所涉及的一些基本概念和流程，有助于更好地理解本次任务的具体工作，在遇到问题时也更容易分析排查。
阅读算子的kernel实现，确定该kernel的哪些输出参数是需要注册DataType的。
参考《Paddle代码贡献指南》，为kernel添加DataType注册信息。
完成本地测试，并提交PR将代码贡献到PaddlePaddle/Paddle仓库中。

注：

PR Add output defs for topk kernel #51233 给出了修复top_k算子的一个具体示例，你可以参照PR描述完成对其它算子的修复。这些case修复难度不大，还能借此了解飞桨的算子开发和注册机制。
该任务时间：PR 截止提交时间是3月31日，截止合入时间是4月3日。
认领规则：直接回复下 issue 下方
PR 通过 CI 后，可以评论里 @From00 ，研发会进行审核
历史上的 good first issue 列表，也欢迎来提 PR 解决~ 欢迎联系花花加入社区，和我们一起快乐开源！

待修复算子列表（整体进度 68/68）

按 merge 的时间顺序，排名不分先后：@From00 (1) @huangjiyi (8) @DrRyanHuang (5) @Liyulingyue (6) @Ainavo (2) @GreatV (3) @jinyouzhi (6) @PPPPzhang (2) @sanbuphy(7) @hellolllw (1) @hellockx (1) @404988613 (1) @Little-chick(1) @junxiu777(1) @ccsuzzh (1) @lubiu (1) @Ackeraa (1) @enkilee (3) @AndPuQing (6) @Difers (2) @Tomoko-hjf (2) @LinearTemporalLogic (1) @AndSonder (7)

序号	算子名称	认领人	修复 PR
1	accuracy✅ (2023/03/09)	@Liyulingyue	#51308
2	all_close✅ (2023/03/12)	@sanbuphy	#51410
3	all_raw✅ (2023/03/12)	@sanbuphy	#51410
4	angle✅ (2023/03/10)	@Liyulingyue	#51314
5	argsort ✅ (2023/03/19)	@sanbuphy	#51407
6	argmax ✅ (2023/03/08)	@DrRyanHuang	#51315
7	argmin ✅ (2023/03/08)	@DrRyanHuang	#51315
8	as_real✅ (2023/03/09)	@Liyulingyue	#51313
9	atan2 ✅ (2023/03/16)	@enkilee	#51312
10	auc ✅ (2023/03/13)	@Little-chick	#51451
11	bincount✅ (2023/03/12)	@hellockx	#51508
12	check_finite_and_unscale ✅ (2023/04/17)	@AndSonder	#52941
13	clip_by_norm ✅ (2023/03/23)	@jinyouzhi	#51993
14	complex ✅ (2023/03/13)	@lubiu	#51478
15	conv3d_coo✅ (2023/03/13)	@sanbuphy	#51516
16	distribute_fpn_proposals✅ (2023/03/13)	@sanbuphy	#51516
17	edit_distance ✅ (2023/03/09)	@jinyouzhi	#51324
18	eig✅ (2023/03/15)	@enkilee	#51319
19	eig_grad ✅ (2023/04/17)	@AndSonder	#52941
20	eigh ✅ (2023/04/11)	@LinearTemporalLogic	#51362
21	eigvals ✅ (2023/03/09)	@GreatV	#51393
22	fft_c2r ✅ (2023/03/19)	@Difers	#51563
23	fft_r2c ✅ (2023/03/19)	@Difers	#51563
24	fused_adam ✅ (2023/03/09)	@jinyouzhi	#51323
25	fused_matmul ✅ (2023/03/13)	@jinyouzhi	#51326
26	generate_proposals✅ (2023/03/16)	sanbuphy	#51576
27	graph_sample_neighbors ✅ (2023/03/29)	@Tomoko-hjf	#51503
28	group_norm ✅ (2023/03/29)	@Tomoko-hjf	#51503
29	histogram✅ (2023/03/14)	@enkilee	#51317
30	instance_norm✅ (2023/03/16)	@sanbuphy	#51576
31	is_empty✅ (2023/03/12)	@hellolllw	#51484
32	is_finite ✅ (2023/03/08)	@DrRyanHuang	#51322
33	kthvalue✅ (2023/03/13)	@junxiu777	#51534
34	lamb✅ (2023/04/17)	@AndSonder	#52941
35	logical_and ✅ (2023/03/08)	@huangjiyi	#51331
36	logical_not ✅ (2023/03/08)	@huangjiyi	#51331
37	logical_or ✅ (2023/03/08)	@huangjiyi	#51331
38	logical_xor ✅ (2023/03/08)	@huangjiyi	#51331
39	lstsq ✅ (2023/03/08)	@huangjiyi	#51333
40	lu ✅ (2023/03/08)	@huangjiyi	#51333
41	matrix_nms ✅ (2023/03/08)	@huangjiyi	#51333
42	matrix_rank_tol✅ (2023/03/08)	@huangjiyi	#51333
43	mode ✅ (2023/03/12)	@ccsuzzh	#51363
44	momentum ✅ (2023/03/24)	@AndPuQing	#51353
45	multiclass_nms3✅ (2023/03/22)	@AndPuQing	#51355
46	multinomial ✅ (2023/03/17)	@AndPuQing	#51357
47	nanmedian✅ (2023/03/23)	@AndPuQing	#51358
48	nms ✅ (2023/03/08)	@Ainavo	#51325
49	nonzero ✅ (2023/03/08)	@Ainavo	#51325
50	numl ✅ (2023/03/10)	@DrRyanHuang	#51356
51	qr ✅ (2023/03/08)	@GreatV	#51311
52	qr_grad ✅ (2023/03/08)	@GreatV	#51311
53	rnn ✅ (2023/03/16)	@AndPuQing	#51360
54	roi_pool✅ (2023/03/08)	@Liyulingyue	#51320
55	search_sort✅ (2023/03/16)	@AndPuQing	#51360
56	select✅ (2023/03/14)	@Ackeraa	#51595
57	send_u_recv ✅ (2023/03/12)	@PPPPzhang	#51501
58	send_ue_recv ✅ (2023/03/12)	@PPPPzhang	#51522
59	sgd ✅ (2023/03/09)	@jinyouzhi	#51332
60	svd ✅ (2023/03/10)	@DrRyanHuang	#51356
61	sync_batch_norm_grad ✅ (2023/04/17)	@AndSonder	#52941
62	top_k ✅ (2023/03/07)	@From00	#51233
63	unique✅ (2023/04/17)	@AndSonder	#52941
64	unique_consecutive_flattened_tensor ✅ (2023/04/17)	@AndSonder	#52941
65	unique_raw ✅ (2023/04/17)	@AndSonder	#52941
66	viterbi_decode✅ (2023/03/09)	@Liyulingyue	#51318
67	viterbi_devode✅ (2023/03/13)	@404988613	#51523
68	yolo_loss ✅ (2023/03/10)	@Liyulingyue	#51316

The text was updated successfully, but these errors were encountered:

paddle-bot · 2023-03-07T07:44:00Z

您好，我们已经收到了您的问题，会安排技术人员尽快解答您的问题，请耐心等待。请您再次检查是否提供了清晰的问题描述、复现代码、环境&版本、报错信息等。同时，您也可以通过查看官网API文档、常见问题、历史Issue、AI社区来寻求解答。祝您生活愉快～

Hi! We've received your issue and please be patient to get responded. We will arrange technicians to answer your questions as soon as possible. Please make sure that you have posted enough message to demo your request. You may also check out the API，FAQ，Github Issue and AI community to get the answer.Have a nice day!

DrRyanHuang · 2023-03-07T11:02:27Z

认领人	任务	内容	PR
DrRyanHuang	6	arg_max	#51315
DrRyanHuang	7	argmin	#51315

enkilee · 2023-03-07T11:30:18Z

atan2

GreatV · 2023-03-07T11:40:44Z

认领人	任务	内容	PR
@GreatV	51	qr	#51311
@GreatV	52	qr_grad	#51311

longranger2 · 2023-03-07T11:42:44Z

认领10、11、12

sanbuphy · 2023-03-07T12:00:50Z

认领2、3、5

Liyulingyue · 2023-03-07T12:01:52Z

认领1、8、4

zade23 · 2023-03-07T12:36:19Z

认领22、23

enkilee · 2023-03-07T12:52:13Z

histogram

zrr1999 · 2023-03-07T12:58:11Z

认领 31.is_empty

jjyaoao · 2023-03-07T13:01:52Z

认领63.unique

Liyulingyue · 2023-03-07T13:04:07Z

68

From00 · 2023-03-13T07:44:15Z

case12 -- check_finite_and_unscale找不到这个文件,

@Little-chick 看下amp_kernel.cc/.cu

Difers · 2023-03-13T08:51:52Z

认领人	任务	内容	PR
@Difers	22	fft_c2r	#51563
@Difers	23	fft_r2c	#51563

认领人任务内容 PR @Difers 22 fft_c2r https://github.com//pull/51563 @Difers 23 fft_c2r https://github.com//pull/51563

kendaji12138 · 2023-03-13T14:05:41Z

认领22,23
#51594

Ackeraa · 2023-03-13T14:22:57Z

认领 case56 #51595

sanbuphy · 2023-04-04T03:19:15Z

认领 63 64 65

AndSonder · 2023-04-11T08:44:52Z

认领人	任务	内容	PR
@AndSonder	12	check_finite_and_unscale	#52941
@AndSonder	19	eig_grad	#52941
@AndSonder	34	lamb	#52941
@AndSonder	63	unique	#52941
@AndSonder	64	unique_consecutive_flattened_tensor	#52941
@AndSonder	65	unique_raw	#52941

luotao1 · 2023-04-17T03:07:21Z

PHI 算子注册信息修复已全部完成，感谢参与的小伙伴们！

按 merge 的时间顺序，排名不分先后：@From00 (1) @huangjiyi (8) @DrRyanHuang (5) @Liyulingyue (6) @Ainavo (2) @GreatV (3) @jinyouzhi (6) @PPPPzhang (2) @sanbuphy(7) @hellolllw (1) @hellockx (1) @404988613 (1) @Little-chick(1) @junxiu777(1) @ccsuzzh (1) @lubiu (1) @Ackeraa (1) @enkilee (3) @AndPuQing (6) @Difers (2) @Tomoko-hjf (2) @LinearTemporalLogic (1) @AndSonder (7)

欢迎继续参与快乐开源的其他任务！

From00 added status/new-issue 新建 type/others 其他问题 good first issue labels Mar 7, 2023

paddle-bot bot assigned haohongxiang Mar 7, 2023

From00 mentioned this issue Mar 7, 2023

Add output defs for topk kernel #51233

Merged

luotao1 assigned luotao1 and From00 and unassigned haohongxiang Mar 7, 2023

luotao1 mentioned this issue Mar 7, 2023

🎁飞桨快乐开源活动表单 #48019

Closed

Liyulingyue mentioned this issue Mar 7, 2023

[phi] add register of accuracy #51308

Merged

luotao1 mentioned this issue Mar 7, 2023

add output defs for qr kernel #51311

Merged

enkilee mentioned this issue Mar 7, 2023

add output defs for atan2 kernel #51312

Merged

Liyulingyue mentioned this issue Mar 7, 2023

[phi] add register of asreal #51313

Merged

Liyulingyue mentioned this issue Mar 7, 2023

[phi] add register of angle #51314

Merged

DrRyanHuang mentioned this issue Mar 7, 2023

[phi] add register of argmax/min #51315

Merged

qili93 mentioned this issue Mar 7, 2023

[Paddle] 主框架 Kernel output datatype 类型修改 PaddlePaddle/PaddleCustomDevice#435

Closed

Liyulingyue mentioned this issue Mar 7, 2023

[phi] Add register of yolo_loss #51316

Merged

enkilee mentioned this issue Mar 7, 2023

add output defs for histogram kernel #51317

Merged

Little-chick mentioned this issue Mar 13, 2023

add register of check_finite_and_unscale #51560

Closed

bbuup mentioned this issue Mar 13, 2023

add register of check_finite_and_unscale #51561

Closed

Difers mentioned this issue Mar 13, 2023

resgister for ftt_r2c, ftt_c2_r #51563

Merged

sanbuphy mentioned this issue Mar 13, 2023

Add output defs for generate_proposals,instance_norm kernel #51576

Merged

kendaji12138 mentioned this issue Mar 13, 2023

add register of fft_r2c,fft_c2r #51594

Closed

Ackeraa mentioned this issue Mar 13, 2023

add register of select #51595

Merged

luotao1 added this to Call for Contributions Mar 16, 2023

luotao1 moved this to In Progress in Call for Contributions Mar 16, 2023

kendaji12138 mentioned this issue Mar 17, 2023

add register of fft_r2c,fft_c2r #51783

Closed

liulinduo mentioned this issue Mar 18, 2023

add register of unique_consecutive_flattened_tensor,unique_raw #51807

Closed

jinyouzhi mentioned this issue Mar 22, 2023

Add output defs for clip_by_norm kernel #51993

Merged

jjyaoao mentioned this issue Mar 31, 2023

[PHI]fix unique dtype infer #52415

Closed

From00 mentioned this issue Apr 2, 2023

Improve new executor static build #51149

Merged

sanbuphy mentioned this issue Apr 4, 2023

Add output defs for unique kernels #52507

Closed

AndSonder mentioned this issue Apr 11, 2023

Add output defs for some kernelsPhi register #52773

Closed

AndSonder mentioned this issue Apr 14, 2023

Add output defs for some kernelsPhi register #52941

Merged

luotao1 closed this as completed Apr 17, 2023

github-project-automation bot moved this from In Progress to Done in Call for Contributions Apr 17, 2023

paddle-bot bot added status/close 已关闭 and removed status/new-issue 新建 labels Apr 17, 2023

AndSonder mentioned this issue Jul 10, 2023

静态图执行器预分析性能优化 #55299

Closed

This was referenced Jul 26, 2023

[Fluid] Migrate Fluid Distributed Kernels to PHI #55716

Closed

中国软件开源创新大赛：飞桨框架任务挑战赛（下） #55663

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Good first issue for phi kernel output definition #51292

Good first issue for phi kernel output definition #51292

From00 commented Mar 7, 2023 •

edited by luotao1

Loading

paddle-bot bot commented Mar 7, 2023

DrRyanHuang commented Mar 7, 2023 •

edited

Loading

enkilee commented Mar 7, 2023

GreatV commented Mar 7, 2023 •

edited

Loading

longranger2 commented Mar 7, 2023

sanbuphy commented Mar 7, 2023

Liyulingyue commented Mar 7, 2023 •

edited

Loading

zade23 commented Mar 7, 2023

enkilee commented Mar 7, 2023

zrr1999 commented Mar 7, 2023

jjyaoao commented Mar 7, 2023

Liyulingyue commented Mar 7, 2023 •

edited

Loading

From00 commented Mar 13, 2023

Difers commented Mar 13, 2023

kendaji12138 commented Mar 13, 2023

Ackeraa commented Mar 13, 2023

sanbuphy commented Apr 4, 2023

AndSonder commented Apr 11, 2023 •

edited

Loading

luotao1 commented Apr 17, 2023 •

edited

Loading

Good first issue for phi kernel output definition #51292

Good first issue for phi kernel output definition #51292

Comments

From00 commented Mar 7, 2023 • edited by luotao1 Loading

问题描述 Please describe your issue

paddle-bot bot commented Mar 7, 2023

DrRyanHuang commented Mar 7, 2023 • edited Loading

enkilee commented Mar 7, 2023

GreatV commented Mar 7, 2023 • edited Loading

longranger2 commented Mar 7, 2023

sanbuphy commented Mar 7, 2023

Liyulingyue commented Mar 7, 2023 • edited Loading

zade23 commented Mar 7, 2023

enkilee commented Mar 7, 2023

zrr1999 commented Mar 7, 2023

jjyaoao commented Mar 7, 2023

Liyulingyue commented Mar 7, 2023 • edited Loading

From00 commented Mar 13, 2023

Difers commented Mar 13, 2023

kendaji12138 commented Mar 13, 2023

Ackeraa commented Mar 13, 2023

sanbuphy commented Apr 4, 2023

AndSonder commented Apr 11, 2023 • edited Loading

luotao1 commented Apr 17, 2023 • edited Loading

From00 commented Mar 7, 2023 •

edited by luotao1

Loading

DrRyanHuang commented Mar 7, 2023 •

edited

Loading

GreatV commented Mar 7, 2023 •

edited

Loading

Liyulingyue commented Mar 7, 2023 •

edited

Loading

Liyulingyue commented Mar 7, 2023 •

edited

Loading

AndSonder commented Apr 11, 2023 •

edited

Loading

luotao1 commented Apr 17, 2023 •

edited

Loading