Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add output defs for atan2 kernel #51312

Merged
merged 11 commits into from
Mar 16, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Mar 7, 2023

PR types

Others

PR changes

APIs

Describe

@paddle-bot paddle-bot bot added the contributor External developers label Mar 7, 2023
@luotao1
Copy link
Contributor

luotao1 commented Mar 8, 2023

@From00 除了 model-benchmark 随机挂外,其余 CI 都通过了,可以进行 review

@luotao1
Copy link
Contributor

luotao1 commented Mar 14, 2023

@enkilee 请解决下冲突

@luotao1
Copy link
Contributor

luotao1 commented Mar 14, 2023

@From00 已经修改完,可以 review

Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atan2InferMeta中只对INT32和INT64类型推导了dtype,需要补充其它类型的推导逻辑。

paddle/phi/kernels/cpu/atan2_kernel.cc Outdated Show resolved Hide resolved
@enkilee enkilee requested a review from From00 March 15, 2023 08:10
@enkilee enkilee requested a review from From00 March 16, 2023 06:33
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@From00 From00 merged commit ab3b87a into PaddlePaddle:develop Mar 16, 2023
@enkilee enkilee deleted the add-output-defs-for-atan2-kernel branch March 16, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants