Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Mv] quantization #51890

Closed
wants to merge 20 commits into from
Closed

[Test Mv] quantization #51890

wants to merge 20 commits into from

Conversation

Liyulingyue
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

@Liyulingyue Liyulingyue mentioned this pull request Mar 20, 2023
Closed
@paddle-bot paddle-bot bot added the contributor External developers label Mar 21, 2023
@paddle-bot
Copy link

paddle-bot bot commented Mar 22, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@Liyulingyue Liyulingyue reopened this Mar 22, 2023
@Liyulingyue
Copy link
Contributor Author

@tianshuo78520a @zhiqiu 好像因为路径问题报错了，麻烦帮忙看一下怎么改比较合适

@tianshuo78520a
Copy link
Collaborator

@tianshuo78520a @zhiqiu 好像因为路径问题报错了，麻烦帮忙看一下怎么改比较合适

看了下python/paddle/static/quantization/tests/CMakeLists.txt文件，在windows上会跳过这几个单测，麻烦添加下。并回复下我上面的问题
image

@Liyulingyue
Copy link
Contributor Author

@tianshuo78520a @zhiqiu 好像因为路径问题报错了，麻烦帮忙看一下怎么改比较合适

看了下python/paddle/static/quantization/tests/CMakeLists.txt文件，在windows上会跳过这几个单测，麻烦添加下。并回复下我上面的问题 image

我更新了测试的语句，挪动到了移除这几个测试的语句后面~

tianshuo78520a
tianshuo78520a previously approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，可以先合入，后续 再提个PR修改下elementwise_op.cc权限或考虑删除单测

paddle/fluid/inference/tensorrt/convert/elementwise_op.cc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么会修改这个文件？做了修改了权限操作？

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Liyulingyue 麻烦看下这个文件权限

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Liyulingyue 麻烦看下这个文件权限

我觉得有点奇怪，暂时先别合入比较好，可能是解决冲突的过程中不小心改动了

@Liyulingyue Liyulingyue mentioned this pull request Mar 30, 2023
Merged
@luotao1 luotao1 closed this Mar 31, 2023
@Liyulingyue Liyulingyue deleted the test1 branch April 6, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianshuo78520a tianshuo78520a tianshuo78520a left review comments

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liyulingyue @tianshuo78520a @luotao1 @zhiqiu