Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[static op generation] lstsq #53290

Merged
merged 11 commits into from
May 10, 2023
Merged

[static op generation] lstsq #53290

merged 11 commits into from
May 10, 2023

Conversation

Liyulingyue
Copy link
Contributor

PR types

Others

PR changes

Others

Description

#53267 case12

@paddle-bot
Copy link

paddle-bot bot commented Apr 24, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 24, 2023
@paddle-bot
Copy link

paddle-bot bot commented Apr 24, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

paddle/phi/api/yaml/ops.yaml Outdated Show resolved Hide resolved
paddle/phi/api/yaml/ops.yaml Show resolved Hide resolved
input :
{x : X, y : Y}
attrs:
{rcond : rcond, driver : driver}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attrs名字一样就不需要映射了,注意阅读相关说明

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented May 3, 2023

Sorry to inform you that 67b18e7's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Comment on lines 1383 to 1386
input :
{x : X, y : Y}
output :
{solution : Solution, residuals : Residuals, rank : Rank, singular_values : SingularValues}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input -> inputs
output -> outputs

{x : X, y : Y}
outputs :
{solution : Solution, residuals : Residuals, rank : Rank, singular_values : SingularValues}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加上:

scalar :
  rcond :
    data_type : float
    support_tensor : true

@Liyulingyue Liyulingyue requested a review from heavyrain-lzy May 9, 2023 03:15
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 4f33f44 into PaddlePaddle:develop May 10, 2023
@Liyulingyue Liyulingyue deleted the lstsq branch May 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants