Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the static op generation for einsum #54723

Merged
merged 5 commits into from
Jul 3, 2023

Conversation

longranger2
Copy link
Contributor

PR types

Others

PR changes

Others

Description

#53267

@paddle-bot
Copy link

paddle-bot bot commented Jun 17, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 17, 2023
@GreatV
Copy link
Contributor

GreatV commented Jun 19, 2023

这个标题是不是写错了,应该是einsum

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 19, 2023
@longranger2 longranger2 changed the title fix the static op generation for group_norm fix the static op generation for einsum Jun 19, 2023
@longranger2
Copy link
Contributor Author

这个标题是不是写错了,应该是einsum

对的,已修改~

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 25, 2023

Sorry to inform you that ec26cfb's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@luotao1
Copy link
Contributor

luotao1 commented Jun 26, 2023

需要重新触发下CI

inputs :
x : Operands
outputs:
{out : Out, inner_cache: InnerCache, xshape : XShape}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加:

drop_empty_grad : [x_grad]
extra : 
  outputs : [inner_cache, xshape]

param : [x, equation]
kernel :
func : einsum
backward : einsum_grad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加

intermediate : inner_cache, xshape

func : UnchangedMultiInferMeta
param : [x_shape]
kernel :
func : einsum_grad
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data_type : out_grad

@heavyrain-lzy
Copy link
Contributor

请根据review意见修改PR,谢谢 @longranger2

@@ -844,6 +844,15 @@
attrs :
uplo : UPLO

- op : einsum
inputs :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加:

backward : einum_grad

@paddle-bot
Copy link

paddle-bot bot commented Jun 30, 2023

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@longranger2
Copy link
Contributor Author

@heavyrain-lzy 修改好了,辛苦review下~

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 1899505 into PaddlePaddle:develop Jul 3, 2023
@longranger2 longranger2 deleted the einsum branch July 8, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants