【Hackathon 8th No.7】Python版本适配 5 #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liyulingyue
commented
Jan 16, 2025
Liyulingyue
commented
Jan 16, 2025
|
This pull request is now in conflict :( |
zxcd
reviewed
Jan 21, 2025
| word, neutral_tone_with_five=True, style=Style.FINALS_TONE3) | ||
| for (word, pos) in seg | ||
| ] | ||
| # after pypinyin==0.41.0, 嗯 will be processed as "", so we need to change it to "n2" |
There was a problem hiding this comment.
- '嗯'
- after 0.44.0
- '嗯' need to be n2, cause the initial and final consonants cannot be empty at the same time
Liyulingyue
commented
Jan 22, 2025
Liyulingyue
commented
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
根据 mozillazg/python-pinyin#284 (comment) ，pypinyin不依赖0.44时，会引入 嗯 韵母空值的情况。
后续将在所有lazy_pinyin的地方临时增加判断以规避此情况，并移除对pypinyin的版本限制。