Compatibility with external deep proxies (rebased) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed _treeMetadataMap to use the unproxified version of the tree, instead of proxified - merged _parenthoodMap into _treeMetadataMap - added a new symbol _metadataSymbol used to access the metadata from the proxified object, but only if you have a reference to the symbol
skip generation of a replace operation, if an object within the tree is replaced with a proxified version of itself by external code
|
Reason this was not merged: I am not merging this until we find it absolutely necessary for view binding. One thing that I find very annoyning about this change is how it affects debugging. Any attempt to read a property from the observed object causes the debugger to step into the Copied from #39 (comment) |
|
Closing because this PR turned out to be not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #39 rebased on current
master.