fix static check warnings

cmd/training/training.go

@@ -51,9 +51,7 @@ func playerTakes(g *game.Game) (takes []constrainedTake) {
 		_kakfa_messages = append(_kakfa_messages, msg)
 
 		fmt.Println(ctk)
-		for _, t := range _ptk {
-			ctk.Takes = append(ctk.Takes, t)
-		}
+		ctk.Takes = append(ctk.Takes, _ptk...)
 		_ptk = append(_ptk, *playerObj.Take)
 		takes = append(takes, ctk)
 	}

cmd/websocket/server.go

@@ -57,9 +57,9 @@ func main() {
 				pid, _ := strconv.Atoi(obj["player_id"])
 				err := g.AddTake(pid, gametake.AllTakesByName[obj["gametake"]])
 				if err != nil {
-					log.Printf(err.Error())
+					log.Println(err.Error())
 				}
-				log.Printf(g.GetTake().Name())
+				log.Println(g.GetTake().Name())
 
 				b := game.BroadcastPlayerTakeMsg(obj["gametake"], id, g.AvailableTakes())
 				for _, p := range g.GetPlayers() {

pkg/broker/kafka.go

@@ -7,8 +7,7 @@ import (
 )
 
 type KafkaPublisher struct {
-	autocreateTopics bool
-	writer           *kafka.Writer
+	writer *kafka.Writer
 }
 
 func NewPublisher(addr []string, autocreateTopics bool) *KafkaPublisher {

pkg/game/events.go

@@ -47,7 +47,7 @@ func SetTakeMsg(gt string, pid int) setTake {
 
 type broadcastPlayerTakeMsg struct {
 	ID             messageID           `json:"id"`
-	Take           string              `json: 'take'`
+	Take           string              `json:"take"`
 	PlayerId       int                 `json:"player_id"`
 	AvailableTakes []gametake.GameTake `json:"available_takes"`
 }

pkg/game/game.go

@@ -12,7 +12,7 @@ import (
 	"pathe.co/zinx/pkg/player"
 )
 
-var CardsAlreadyDispatchedError = errors.New("Cards already dispatched error")
+var ErrCardsAlreadyDispatched = errors.New("cards already dispatched error")
 
 type Game struct {
 	Cartes            [32]cards.Card
@@ -129,7 +129,7 @@ func (g *Game) AvailableTakes() []gametake.GameTake {
 
 func (g *Game) DispatchCards() error {
 	if g.CartesDistribuees == 32 {
-		return CardsAlreadyDispatchedError
+		return ErrCardsAlreadyDispatched
 	}
 
 	for _, p := range g.players {

pkg/game/game_test.go

@@ -108,7 +108,7 @@ func TestDispatchCardsIsIdempotent(t *testing.T) {
 	g := setupGame(4)
 	g.DispatchCards()
 
-	assert.Error(t, g.DispatchCards(), CardsAlreadyDispatchedError)
+	assert.Error(t, g.DispatchCards(), ErrCardsAlreadyDispatched)
 }
 
 func TestNewGame(t *testing.T) {

pkg/player/player.go

@@ -83,9 +83,7 @@ func (p *Player) OrderedCardsForTake(t gametake.GameTake) [5]cards.Card {
 	result := []cards.Card{}
 
 	for _, cards := range m {
-		for _, c := range cards {
-			result = append(result, c)
-		}
+		result = append(result, cards...)
 	}
 
 	return [5]cards.Card(result)
@@ -109,9 +107,7 @@ func (p *Player) OrderedCardsForPlaying(t gametake.GameTake) [8]cards.Card {
 	result := []cards.Card{}
 
 	for _, cards := range m {
-		for _, c := range cards {
-			result = append(result, c)
-		}
+		result = append(result, cards...)
 	}
 
 	return [8]cards.Card(result)

pkg/router/set_player_take_router.go

@@ -12,7 +12,7 @@ type PlayerTakeRouter struct {
 }
 
 // PlayerTake Handle
-func (this *PlayerTakeRouter) Handle(request ziface.IRequest) {
+func (ptr *PlayerTakeRouter) Handle(request ziface.IRequest) {
 	fmt.Println("Call PlayerTakeRouter Handle")
 	fmt.Println("recv from client: msgId=", request.GetMsgID(), ", data=")
 

utils/globalobj.go

@@ -2,7 +2,7 @@ package utils
 
 import (
 	"encoding/json"
-	"io/ioutil"
+	"os"
 
 	"pathe.co/zinx/ziface"
 )
@@ -42,7 +42,7 @@ Define a global object
 var GlobalObject *GlobalObj
 
 func (g *GlobalObj) Reload() error {
-	data, err := ioutil.ReadFile("conf/zinx.json")
+	data, err := os.ReadFile("conf/zinx.json")
 	if err != nil {
 		return err
 	}

znet/connection.go

@@ -73,7 +73,7 @@ func (c *Connection) StartWriter() {
 				}
 			} else {
 				fmt.Println("msgBuffChan is Closed")
-				break
+				return
 			}
 
 		case <-c.ExitBuffChan:

znet/msghandler.go

@@ -49,10 +49,8 @@ func (mh *MsgHandle) AddRouter(msgId uint32, router ziface.IRouter) {
 func (mh *MsgHandle) StartOneWorker(workerID int, taskQueue chan ziface.IRequest) {
 	fmt.Println("Worker ID =", workerID, "is started.")
 	for {
-		select {
-		case request := <-taskQueue:
-			mh.DoMsgHandler(request)
-		}
+		request := <-taskQueue
+		mh.DoMsgHandler(request)
 	}
 }