Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up JavaPluginLoader and VelocityPluginModule #1140

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Clean up JavaPluginLoader and VelocityPluginModule #1140

merged 2 commits into from
Jan 4, 2024

Conversation

alexstaeding
Copy link
Contributor

@alexstaeding alexstaeding commented Nov 13, 2023 •
edited
Loading

This PR cleans up some small issues I noticed while browsing in the JavaPluginLoader and VelocityPluginModule classes:

  • Use Optional#isEmpty instead of negation of isPresent
  • Add missing optional check for candidate.getSource()
  • Replace raw types with wildcards
  • Remove redundant throws Exception
  • Remove redundant ProxyServer parameter from VelocityPluginModule

@electronicboy electronicboy merged commit 897ff81 into PaperMC:dev/3.0.0 Jan 4, 2024
pull bot pushed a commit to WiIIiam278/Velocity that referenced this pull request Jan 6, 2024
@alexstaeding @pull
Clean up JavaPluginLoader and VelocityPluginModule (PaperMC#1140)
cd0947d
skbeh pushed a commit to skbeh/Velocity that referenced this pull request Jan 17, 2024
@alexstaeding @skbeh
Clean up JavaPluginLoader and VelocityPluginModule (PaperMC#1140)
725315f
@4drian3d 4drian3d added this to the Velocity 3.3.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@electronicboy electronicboy electronicboy approved these changes

@4drian3d 4drian3d 4drian3d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Velocity 3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexstaeding @electronicboy @4drian3d