Add Configuration State API

[4drian3d]

Added events for when a player enters and finishes the configuration phase.
This, along with pull request #1224 would implement a functional way to check the State in which the player is in

blocked by #1224
resolves #1120

[SasaBrix]

Are there any new updates?

[4drian3d]

Are there any new updates?

I am waiting for some comments in order to improve this pull request, if you have something to contribute or any suggestion, you are welcome to do it

[SandwichBtw]

Is there anything else specifically that needs to be done before this could get merged? Just wondering if there's any plan other than just waiting on comments.

[Luccboy]

This is probably unimportant, but I noticed that Configuration phase is sometimes written with a capital c and sometimes with a lowercase c in the JavaDocs. Maybe you want to keep the spelling consistent?

[Gerrygames]

I think there is currently no way to know to which server the player is currently connecting to when PlayerFinishConfigurationEvent or PlayerFinishedConfigurationEvent are called. Should probably add the ServerConnection to all configuration events.

[electronicboy]

The players current server should be switched when they enter configuration for that server, IMHO; iirc, that was missing, however (and has generally been a source of a whole bunch of other issues over the past while)

[Gerrygames]

Currently the current server isnt set until after ServerConnectedEvent has been called which is done when handling the join game packet.

[Gerrygames]

Blocking the PlayerFinishConfigurationEvent for more than ~30 seconds was not possible because the backend server would experience a timeout. I fixed this with the latest commit by not disabling auto-reading and instead modifying the PlayPacketQueueHandler to also queue inbound play packets.

[ammodev]

Is there any updates on this? I would really enjoy using this api without having to manually build velocity. Iirc theres nothing to be done here, correct?

[twisti-dev]

Are there any plans to merge this?

[4drian3d]

Are there any plans to merge this?

Yes

[Keviro]

Are there any plans to merge this?

There are plans, there is just no one executing them xD

[Timongcraft]

Are there any plans to merge this?

There are plans, there is just no one executing them xD

I think they want to bump the version first.

[ammodev]

Are there any plans to merge this?

There are plans, there is just no one executing them xD

I think they want to bump the version first.

What else is missing to bump the version then? https://github.com/PaperMC/Velocity/milestone/6

[twisti-dev]

Hi, just wanted to follow up and see if there are any updates on merging this PR. It looks like everything is ready. Is there anything else that needs to be done before this can be merged?

Thanks!