Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose server build information #1336

Draft
wants to merge 8 commits into
base: dev/3.0.0
Choose a base branch
from
Draft

feat: Expose server build information #1336

wants to merge 8 commits into from

Conversation

powercasgamer
Copy link
Contributor

@powercasgamer powercasgamer commented May 29, 2024 •
edited
Loading

PaperMC/Paper#10729

WindowsTerminal_q4pzY4EoVQ

Still a work in progress

  • 'Fix' the -DEV stuff, Velocity 3.3.0-SNAPSHOT-DEV-feat/buildinfo@291918e5 (2024-05-29T22:31:46Z) looked ugly to me but, opinions
  • not sure what to do with versionName and versionId
  • Not sure what to do with Specification-Version, Implementation-Version
  • Make sure this actually works one merged lol
  • Stupid javadocs for internal classes??
  • Separate BuildInfo into it's own project (@kashike)
  • Adventure? (Clickable commit message)
  • Potentially change the /velocity info message, especially the colors.

checkstyle sucks

@kashike kashike self-requested a review May 30, 2024 03:09
@powercasgamer powercasgamer force-pushed the feat/buildinfo branch 3 times, most recently from ebb43aa to 3b9f323 Compare May 30, 2024 22:45
@powercasgamer powercasgamer changed the title feat: build info feat: Expose server build information May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashike kashike Awaiting requested review from kashike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@powercasgamer