-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PlayerConfigurationEvent and PlayerEnteredConfigurationEvent #1371
Conversation
…erMC#1371) * Configuring the player (i.e. sending resource packs) should now be done in the new PlayerConfigurationEvent. * The new PlayerEnteredConfigurationEvent is called when a player acknowledged the switch to configuration state. * The PlayerEnterConfigurationEvent is no longer called twice. It is now called when the backed wants to reconfigure the player. * The PlayerFinishConfigurationEvent should no longer be used to configure the player (i.e. sending resource packs). This is because since 1.20.5 the backend server can't send keep alive packets between switching state anymore and the connection will thus time out.
…erMC#1371) * Configuring the player (i.e. sending resource packs) should now be done in the new PlayerConfigurationEvent. * The new PlayerEnteredConfigurationEvent is called when a player acknowledged the switch to configuration state. * The PlayerEnterConfigurationEvent is no longer called twice. It is now called when the backed wants to reconfigure the player. * The PlayerFinishConfigurationEvent should no longer be used to configure the player (i.e. sending resource packs). This is because since 1.20.5 the backend server can't send keep alive packets between switching state anymore and the connection will thus time out.
Is it intentional that the new |
No that's a mistake then. I will investigate that later. |
I just noticed that the Javadoc for the |
The "clientbound" connection between velocity and the backend is already in configuration state but the clientbound connection between velocity and the client is still in play state. The java doc states that the backend can't keep the connection alive during state changes which is correct. If you have any better wording for it, you're welcome to suggest it. |
How about this? * <p>Velocity will wait for this event before asking the client to enter configuration state.
* <br>However, for the backend server, the player is already in the configuration state. Since the server cannot maintain the connection during state changes,
* Velocity will only wait for a maximum of 5 seconds.</p>
|
Have you found anything? |
Fixed by d999ee2 |
This addresses issues #1367 and #1368