replace old velocitypowered.com links #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4drian3d
approved these changes
Aug 1, 2024
| @@ -174,10 +174,10 @@ public int run(final CommandContext<CommandSource> context) { | |||
| if (version.getName().equals("Velocity")) { | |||
| final TextComponent embellishment = Component.text() | |||
| .append(Component.text() | |||
| .content("velocitypowered.com") | |||
| .content("papermc.io/software/velocity") | |||
There was a problem hiding this comment.
This looks really meh
There was a problem hiding this comment.
yeah, any suggestions to make it better?
Something like: Info
There was a problem hiding this comment.
Yeah idk it doesn't really make sense. Maybe since it's a PaperMC software, it can be replaced with papermc.io? Or just leave it really it doesn't hurt anybody.
There was a problem hiding this comment.
At least old link still works and redirects to desired place
There was a problem hiding this comment.
if I were held at gunpoint, I'd probably just maybe name it PaperMC, anything else is just pointlessly verbose, imho
RealBauHD
force-pushed
the
replace-old-links
branch
from
e3d0580
to
c49727b
Compare
RealBauHD
commented
Sep 14, 2024
| @@ -174,10 +174,10 @@ public int run(final CommandContext<CommandSource> context) { | |||
| if (version.getName().equals("Velocity")) { | |||
| final TextComponent embellishment = Component.text() | |||
| .append(Component.text() | |||
| .content("velocitypowered.com") | |||
| .content("PaperMC") | |||
There was a problem hiding this comment.
Any opinions on also underline this?
pull bot
pushed a commit
to WiIIiam278/Velocity
that referenced
this pull request
Oct 30, 2024
* replace old links * content to 'PaperMC', cause its probably the best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
velocitypowered.com, because they are now being forwarded anyway, and so we can avoid the detour.