Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup #403

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Test cleanup #403

merged 3 commits into from
Jul 26, 2017

Conversation

bording
Copy link
Member

@bording bording commented Jul 21, 2017

Two changes here. The first is that AcceptanceTests now uses QueueBindings to know what queues to purge, like we were already doing in TransportTests. I tweaked the TransportTests implemenation so that both are consistent.

I also removed some unneeded code from the APIApprovals test, which had the side effect of introducing some whitespace in the approval file.

@bording bording requested a review from a team July 21, 2017 21:06
@bording bording force-pushed the test-cleanup branch 2 times, most recently from 3450383 to adf461a Compare July 22, 2017 05:14
@bording
Copy link
Member Author

bording commented Jul 22, 2017

I found that TeamCity has a plugin that should get test reporting for .NET Core, but it seems to be exploding all the tests. I'll figure this out next week.

@bording bording changed the title Test cleanup [WIP] Test cleanup Jul 22, 2017
@bording bording force-pushed the test-cleanup branch 2 times, most recently from 8c5c78f to 79166b2 Compare July 24, 2017 22:55
@bording
Copy link
Member Author

bording commented Jul 24, 2017

Even after fixing one of the issues with the TeamCity plugin, I was still seeing Could not find a test logger with URI or FriendlyName 'teamcity', so I decided to remove it from this PR, and I'll try again later in a separate PR.

The reason we've had 5 failing tests initially was because by removing the "wipe all queues between tests" logic, we're now hitting #134 for those tests. 😢 The reset broker script was also not working correctly, guaranteeing we'd have leftover messages that would cause the tests to fail.

I've got the reset script working again on the .NET Core build agent, and that seems to have the sequencing correct to not cause a test failure, but #134 is still lurking in those tests.

I'll have to see If I can get the tests changed in Core to ensure we don't have a problem since I don't know of another workaround.

@bording bording changed the title [WIP] Test cleanup Test cleanup Jul 24, 2017
@adamralph adamralph merged commit 154b3d0 into develop Jul 26, 2017
@adamralph adamralph deleted the test-cleanup branch July 26, 2017 11:14
@adamralph adamralph added this to the 5.0.0 milestone Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants