[wip] [spike] Minimize HTTP API console windows #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @timbussmann |
timbussmann
reviewed
Sep 5, 2018
| { | ||
| public static void TryMinimize() | ||
| { | ||
| if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) |
There was a problem hiding this comment.
is that check really necessary when targeting the .NET Framework?
There was a problem hiding this comment.
@timbussmann it's an edge case, but you could run it on Mono on *nix. But in any case, we want to move to .NET Core ASAP anyway, so I'd rather include this check now.
|
|
|
I'll raise a proper PR to get this in if/when the opportunity arises. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #295.
This will do it. Note that it needs
net471or higher, or a switch to any version ofnetcoreapp: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.runtimeinformation#applies-toIf we like it, we need to think about how to get this code into all the API projects. I'm reluctant to duplicate it.