Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to ASB metrics permission needed #6904

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

andreasohlund
Copy link
Member

No description provided.

Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreasohlund overall I don't think is a bad idea to align the permissions but I think the throughput-tool requires different permissions then the integrated throughput in ServicePulse, example I don't think the earlier needs "subscription read".
Any thoughts @DavidBoike ?

@DavidBoike
Copy link
Member

ServiceControl definitely needs more permissions. It would probably be better to just identify the Monitoring Reader role and link to it, if that's indeed all that it needs. Would that be enough permissions to enumerate the queues?

I think it's unlikely that someone would want to create a custom role (something you can't even do without Entra Premium or whatever) to run a once-a-year tool…only for provisioning permanent ServiceControl access via a principal.

@andreasohlund
Copy link
Member Author

Monitoring Reader has permission to read queues which is all we need so changing to link directly to that role

@andreasohlund andreasohlund merged commit aa71c88 into master Nov 25, 2024
4 checks passed
@andreasohlund andreasohlund deleted the link-to-sp-section branch November 25, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants