Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #37 #40

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Fixes #37 #40

merged 4 commits into from
Sep 24, 2024

Conversation

senseiwells
Copy link
Contributor

  • Updated dependencies to 1.21.1

  • Implemented getHotbarSlotIndex and getOffhandSlotIndex methods to SlotGuiInterface, this allows each gui to define where the hotbar slots and offhand slots are located, this fixes numerous issues with HotbarGuis desyncing.

  • Fixes other incorrect syncing with HotbarGui by sending the correct data to the client instead of modifying the previously sent slots.

  • Also fixes an issue where in any non-hotbar gui you could desync items into the offhand, if a player previously had an item in their offhand when a gui opens it will now not display that item.

@senseiwells senseiwells marked this pull request as draft September 24, 2024 13:55
@senseiwells senseiwells marked this pull request as ready for review September 24, 2024 14:18
@Patbox Patbox merged commit 67d2119 into Patbox:1.21 Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants