Skip to content

Commit

Permalink
Other fix for assertion violations
Browse files Browse the repository at this point in the history
  • Loading branch information
Paul-Licameli committed Nov 5, 2023
1 parent 61ab08c commit de4577c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 2 additions & 2 deletions libraries/lib-track/PendingTracks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ PendingTracks::PendingTracks(AudacityProject &project)
// Pass along to downstream listeners
Publish(event);
})}
, mPendingUpdates{ TrackList::Temporary(nullptr) }
, mPendingUpdates{ TrackList::Temporary(mTracks.GetOwner()) }
{}

PendingTracks::~PendingTracks() = default;
Expand Down Expand Up @@ -199,7 +199,7 @@ void PendingTracks::ClearPendingTracks(std::vector<TrackListHolder> *pAdded)
bool PendingTracks::ApplyPendingTracks()
{
std::vector<TrackListHolder> additions;
auto updated = TrackList::Temporary(nullptr);
auto updated = TrackList::Temporary(mTracks.GetOwner());
{
// Always clear, even if one of the update functions throws
Finally Do{[&]{ ClearPendingTracks(&additions); }};
Expand Down
6 changes: 1 addition & 5 deletions src/TrackArt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "TrackPanelDrawingContext.h"
#include "ZoomInfo.h"
#include "TimeDisplayMode.h"
#include "PendingTracks.h"
#include "ProjectTimeRuler.h"

#include "ProjectTimeSignature.h"
Expand Down Expand Up @@ -711,16 +710,13 @@ void TrackArt::DrawBackgroundWithSelection(
const auto artist = TrackArtist::Get( context );
const auto &selectedRegion = *artist->pSelectedRegion;
const auto& zoomInfo = *artist->pZoomInfo;
const auto &pendingTracks = *artist->pPendingTracks;


//MM: Draw background. We should optimize that a bit more.
const double sel0 = useSelection ? selectedRegion.t0() : 0.0;
const double sel1 = useSelection ? selectedRegion.t1() : 0.0;

// This works around assertion violations
auto orig = pendingTracks.SubstituteOriginalTrack(*track);
BeatsGridlinePainter gridlinePainter(zoomInfo, *orig);
BeatsGridlinePainter gridlinePainter(zoomInfo, *track);

dc->SetPen(*wxTRANSPARENT_PEN);

Expand Down

0 comments on commit de4577c

Please sign in to comment.