Ci e2e flake #6
Merged
Ci e2e flake #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Window got a little smaller with move to new github action with Node 20?
fix(windowing): more robust loading of multi-component DICOMs
…ection If user selected segmentation that is being converted to a segment group before convert was done, built image would be deleted while looking at the segment group. This would cause endless spinner to appear. Also, fix layer.e2e test in CI
Avoids Pinia $onAction magic on delete calls. components call datasetStore.remove, rather than imageStore or dicomStore delete.
Was trying to get StudyUID with imageID key.
Automatically convert SEG DICOMs to Segment Groups
If a secondary DataSource has a name like foo.segmentation.bar and the primary DataSource is named foo.baz, the secondary DataSource will be loaded as a segment group.
More consistent with Array JS functions.
Moves loadDataSources logic to composable, keeps store mostly state.
Auto Segment Group by name
When holding left mouse down, points are dropped.
Bug reproduction steps: 1. Load prostate sample 2. Switch to Rendering tab 3. Load Fetus sample Error: VolumeRendering component would get an empty string preset, then fail to get a color transfer function from that. This change initializes the volume-coloring store for a dataset in all components that depend on volume-coloring.
Segment Groups: opacity slider and visibility toggle button
fix(VolumeRendering): on switching dataset, ensure CTF preset valid
Update @itk-wasm/dicom for new SEG pipeline
feat(camera): Add option to disable camera auto reset
Synchronize cameras images
fix(crop): wait for DICOM image load
No need to click in list.
For readability.
… logic Rename functions using labelMap to segmentGroup
Segments: opacity slider and visibile toggle
fix: vtk.js version not showing up
fix(updateFileMimeType): overwrite mimetype
fix(PatientStudyVolumeBrowser): show modality if thumbnail fails
feat(global.css): increase tooltip background opacity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.