[Feature] 이동봉사 신청 API 구현 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
hojeong2747
approved these changes
Nov 12, 2023
| @NotBlank(message = "교통수단은 필수 입력 값입니다.") | ||
| String transportation, | ||
| @Size(min=10, max=200, message = "10~200자의 내용을 작성해 주세요.") | ||
| String content) { |
There was a problem hiding this comment.
입력 필드 값 validation 멘트 통일하면 좋을 것 같아요! 지금은 다 다르게 되어 있는데, 닉네임은 2~10자로 입력해 주세요. 이런 식으로 필드명은 몇자로 입력해 주세요. 로 맞추면 어떨까요~? 더 좋은 멘트가 있으려나요?
There was a problem hiding this comment.
좋습니다! @ NotBlank에 대한 멘트도 통일하는 게 좋을까요?
There was a problem hiding this comment.
필드명은 필수 입력 값입니다. 로 통일하면 좋을 것 같습니다~!
| applicationRepository.save(application); | ||
|
|
||
| // 공고 상태 승인 대기 중으로 변경 | ||
| post.updateStatus(PostStatus.WAITING); |
There was a problem hiding this comment.
값 존재 여부부터 저장 및 갱신까지 깔끔합니다 👍
| "P2, 해당 공고를 찾을 수 없습니다. \t\n AP1, 이미 신청된 공고입니다." | ||
| , content = @Content(schema = @Schema(implementation = ErrorResponse.class))) | ||
| }) | ||
| @PostMapping("/volunteers/posts/{postId}/applications") |
There was a problem hiding this comment.
확실히 uri를 계층 구조 분리해서 작성하니 이해하기 편하네요~! 리뷰랑 엮어서 생각하니 좋습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 연관된 이슈
close #52
📝 작업 내용
💬 리뷰 요구 사항