few changes to fix issues #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/pinterest/secor/common/AvroSchemaRegistry.java # src/main/java/com/pinterest/secor/common/ConfigurableAvroSchemaRegistry.java # src/main/java/com/pinterest/secor/common/SecorSchemaRegistryClient.java # src/main/java/com/pinterest/secor/io/impl/AvroParquetFileReaderWriterFactory.java # src/test/java/com/pinterest/secor/io/impl/AvroParquetFileReaderWriterFactoryTest.java
# Conflicts: # src/main/java/com/pinterest/secor/util/orc/VectorColumnFiller.java
# Conflicts: # src/main/java/com/pinterest/secor/reader/SecorKafkaMessageIterator.java # src/main/java/com/pinterest/secor/util/orc/JsonFieldFiller.java
ruccoon
reviewed
May 14, 2020
| @@ -68,7 +68,6 @@ public GenericRecord deserialize(String topic, byte[] message) { | |||
| GenericRecord record = (GenericRecord) deserializer.deserialize(topic, message); | |||
| if (record != null) { | |||
| Schema schema = record.getSchema(); | |||
| schemas.put(topic, schema); | |||
There was a problem hiding this comment.
hi @dorjeetsering, just curious here, do we need remove this line, looks like nothing get updated to the record
There was a problem hiding this comment.
That's the main change we want. We can remove the null check block.
if (record != null) {
Schema schema = record.getSchema();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made few changes while running secor for input team and signal secor