Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git hooks from bety helm chart #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,21 @@ description: >
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.5.4
version: 0.5.5

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: "5.4.1"
appVersion: "5.4.2"

# List of people that maintain this helm chart.
maintainers:
- name: Rob Kooper
email: [email protected]
- name: Aju Tamang
email: [email protected]
- name: Sagar Utekar
email: [email protected]

# location of source code
sources:
Expand All @@ -44,3 +46,4 @@ annotations:
url: https://github.com/pecanproject/bety-helm
artifacthub.io/changes: |
- back to hooks since job completion requires RBAC role
- Removing hook backs for helm chart to run faster
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ The command removes all the Kubernetes components associated with the chart and

## ChangeLog

### 0.5.5
- Removing hooks to run helm chart quicker

### 0.5.4
- back to hooks since job completion requires RBAC role

Expand Down
6 changes: 3 additions & 3 deletions templates/hooks/add-user.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ metadata:
# This is what defines this resource as a hook. Without this line, the
# job is considered part of the release.
# TODO once we have RBAC we can use initContainers to wait for a job
"helm.sh/hook": "post-install"
"helm.sh/hook-delete-policy": "pre-delete"
"helm.sh/hook-weight": "10"
#"helm.sh/hook": "post-install"
#"helm.sh/hook-delete-policy": "pre-delete"
#"helm.sh/hook-weight": "10"
spec:
template:
metadata:
Expand Down
6 changes: 3 additions & 3 deletions templates/hooks/load-db.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ metadata:
annotations:
# This is what defines this resource as a hook. Without this line, the
# job is considered part of the release.
"helm.sh/hook": "post-install"
"helm.sh/hook-delete-policy": "pre-delete"
"helm.sh/hook-weight": "5"
#"helm.sh/hook": "post-install"
#"helm.sh/hook-delete-policy": "pre-delete"
#"helm.sh/hook-weight": "5"
spec:
template:
metadata:
Expand Down