Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unlock cancel flow #142

Merged

Conversation

rileystephens28
Copy link
Member

Bug Description

When a user navigates to the send page while the keyring is in a locked state, the cancel flow does not work. Clicking the cancel button on the unlock screen attempts to navigate the user back to the send page, which then automatically redirects back to the unlock page. This results in a user being stuck on the unlock page until the correct password is entered.

Solution

When cancel button is clicked, find the last visited eligible path to navigate back to where an eligible path is defined as any path that does not automatically redirect to the unlock page. As of now the only ineligible paths are /send and /keyring/unlock.

@jdowning100
Copy link
Collaborator

Looks good to me. Does the linter automatically run? If not, can we have it automatically run after the file is saved, or a commit is added? This would be easier than having to manually run it.

@rileystephens28
Copy link
Member Author

Linting is configured in pre-commit, github build.yml and can be manually run using one of the eight scripts declared in package.json. I will to double check that the prettier/eslint configs are universal for all these methods of linting in a future PR.

@rileystephens28 rileystephens28 merged commit fc3d9f7 into PelagusWallet:main Feb 15, 2024
3 of 5 checks passed
@rileystephens28 rileystephens28 deleted the fix-unlock-cancel-flow branch February 23, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants