Simplify logic in default qubit sampling #6390
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We added some bepoke grouping logic back when developing the sampling logic because
split_non_commuting
was not general enough for our purposes. Now we do havesplit_non_commuting
anddiagonalize_measurements
, so we can remove the bepoke grouping logic.Description of the Change:
Removes the unique grouping logic in favor of simply relying on
split_non_commuting
anddiagonalize_measurements
.Benefits:
Simpler code, less duplication.
Possible Drawbacks:
Related GitHub Issues: