Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic in default qubit sampling #6390

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Oct 11, 2024

Context:

We added some bepoke grouping logic back when developing the sampling logic because split_non_commuting was not general enough for our purposes. Now we do have split_non_commuting and diagonalize_measurements, so we can remove the bepoke grouping logic.

Description of the Change:

Removes the unique grouping logic in favor of simply relying on split_non_commuting and diagonalize_measurements.

Benefits:

Simpler code, less duplication.

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant