Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource operators for Adjoint, Controlled, and Pow #6592

Merged
merged 507 commits into from
Dec 6, 2024

Conversation

willjmax
Copy link
Contributor

This PR contains the ResourceOperator implementations for symbolic operators.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (5410faa) to head (6baf431).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6592   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         468      468           
  Lines       44254    44254           
=======================================
  Hits        44096    44096           
  Misses        158      158           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from resource_multi_qubit to master December 3, 2024 22:22
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good! Left a few suggestions but it's looking much better now !

Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. Left a few comments regarding the documentation. Im happy to approve once those are addressed.

Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditional to codefactor issues being fixed.

@Jaybsoni Jaybsoni enabled auto-merge (squash) December 6, 2024 19:28
@Jaybsoni Jaybsoni merged commit 32236c1 into master Dec 6, 2024
46 checks passed
@Jaybsoni Jaybsoni deleted the resource_symbolic_ops branch December 6, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants