-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource operators for Adjoint, Controlled, and Pow #6592
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6592 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 468 468
Lines 44254 44254
=======================================
Hits 44096 44096
Misses 158 158 ☔ View full report in Codecov by Sentry. |
…nnylane into resource_qft
…resource_symbolic_ops
…resource_single_qubit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good! Left a few suggestions but it's looking much better now !
pennylane/labs/tests/resource_estimation/ops/op_math/test_symbolic.py
Outdated
Show resolved
Hide resolved
pennylane/labs/tests/resource_estimation/ops/op_math/test_symbolic.py
Outdated
Show resolved
Hide resolved
pennylane/labs/tests/resource_estimation/ops/op_math/test_symbolic.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jay Soni <[email protected]>
…ane into resource_symbolic_ops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go. Left a few comments regarding the documentation. Im happy to approve once those are addressed.
Co-authored-by: Jay Soni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving conditional to codefactor issues being fixed.
This PR contains the ResourceOperator implementations for symbolic operators.