Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Christiansen mapping for mapping christiansen bosons #6623

Merged
merged 105 commits into from
Nov 27, 2024

Conversation

ddhawan11
Copy link
Contributor

@ddhawan11 ddhawan11 commented Nov 21, 2024

Context:
Add christiansen_mapping function

Description of the Change:
Added function for mapping hardcore bosonic operators to qubit operators using christiansen mapping

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-72640]

@ddhawan11 ddhawan11 changed the base branch from bose_operators to master November 21, 2024 17:14
@ddhawan11 ddhawan11 changed the title Add Christiansen mapping for mapping hardcore bosons Add Christiansen mapping for mapping christiansen bosons Nov 21, 2024
pennylane/qchem/vibrational/bosonic_mapping.py Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/qchem/vibrational/bosonic_mapping.py Outdated Show resolved Hide resolved
pennylane/qchem/vibrational/bosonic_mapping.py Outdated Show resolved Hide resolved
pennylane/qchem/vibrational/bosonic_mapping.py Outdated Show resolved Hide resolved
Copy link
Contributor

@austingmhuang austingmhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a look at some general stuff. Seems like the algorithm is not that complicated but I will double check tomorrow.

tests/qchem/vibrational_tests/test_christiansen_mapping.py Outdated Show resolved Hide resolved
pennylane/qchem/vibrational/bosonic_mapping.py Outdated Show resolved Hide resolved
pennylane/qchem/vibrational/bosonic_mapping.py Outdated Show resolved Hide resolved
tests/qchem/vibrational_tests/test_christiansen_mapping.py Outdated Show resolved Hide resolved
tests/qchem/vibrational_tests/test_christiansen_mapping.py Outdated Show resolved Hide resolved
@ddhawan11 ddhawan11 marked this pull request as ready for review November 25, 2024 10:39
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (a672a9b) to head (b16e61c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6623      +/-   ##
==========================================
+ Coverage   99.46%   99.65%   +0.18%     
==========================================
  Files         455      455              
  Lines       42784    42818      +34     
==========================================
+ Hits        42555    42669     +114     
+ Misses        229      149      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ddhawan11, looks good.

pennylane/bose/bosonic_mapping.py Outdated Show resolved Hide resolved
pennylane/bose/bosonic_mapping.py Outdated Show resolved Hide resolved
pennylane/bose/bosonic_mapping.py Outdated Show resolved Hide resolved
pennylane/bose/bosonic_mapping.py Outdated Show resolved Hide resolved
tests/bose/test_christiansen_mapping.py Outdated Show resolved Hide resolved
tests/bose/test_christiansen_mapping.py Show resolved Hide resolved
pennylane/bose/bosonic_mapping.py Show resolved Hide resolved
tests/bose/test_christiansen_mapping.py Outdated Show resolved Hide resolved
pennylane/bose/bosonic_mapping.py Outdated Show resolved Hide resolved
@ddhawan11 ddhawan11 merged commit b8d0b91 into master Nov 27, 2024
46 checks passed
@ddhawan11 ddhawan11 deleted the christiansen_mapping branch November 27, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants