-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transforms can be captured with PLxPR #6633
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6633 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 459 459
Lines 43217 43262 +45
=======================================
+ Hits 43068 43113 +45
Misses 149 149 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, no blockers from me.
It seems to me that we are not systematically using type hints anymore, so I guess this should not be a requirement for new changes in the codebase
Co-authored-by: Pietropaolo Frisoni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Christina Lee <[email protected]>
[sc-72804] [sc-72803]
This PR adds a primitive for capturing transforms.
Description of change
TransformProgram
as well so that executing QNodes applies the transform(s) to the constructed tape, and also captured as a primitive.plxpr_transform
attribute toTransformDispatcher
andTransformContainer
. This is not currently used and is being added here to set up scaffolding inpennylane.transfoms.core
for AddTransformTrace
,TransformTracer
andTransformInterpreter
classes for transforming PLxPR #6389 .Benefits
Transforms can be captured into PLxPR and no extra work is required when creating new transforms