added proptest & impl Arbitrary traits for quote #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leechael
force-pushed
the
feat-arbitrary
branch
from
2c5f157 to
01b0e75
Compare
kvinwang
reviewed
Oct 25, 2024
| @@ -36,13 +51,89 @@ pub struct Header { | |||
| pub user_data: [u8; 20], | |||
| } | |||
|
|
|||
| #[derive(Decode, Debug)] | |||
| impl Arbitrary for Header { | |||
There was a problem hiding this comment.
Code readability suffers when implementing traits manually like this, and it's error-prone. Consider using #[derive(Arbitrary)] instead.
| T: Encode + TryFrom<usize>, | ||
| <T as TryFrom<usize>>::Error: std::fmt::Debug, | ||
| { | ||
| fn encode(&self) -> Vec<u8> { |
There was a problem hiding this comment.
Prefer implementing fn encode_to rather than fn encode to avoid one extra heap allocation + data copying.
| @@ -181,6 +529,16 @@ impl Decode for AuthDataV4 { | |||
| } | |||
| } | |||
|
|
|||
| impl Encode for AuthDataV4 { | |||
| fn encode(&self) -> Vec<u8> { | |||
Comment on lines
+23
to
+24
| let mut encoded = vec![]; | ||
| header.encode_to(&mut encoded); |
There was a problem hiding this comment.
Suggested change
| let mut encoded = vec![]; | |
| header.encode_to(&mut encoded); | |
| let encoded = header.encode(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Arbitrary trait to each Quote struct to simplify mocking and testing.