Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display with default max of 100 if max not set #1127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bellerbrock
Copy link
Collaborator

Description

Modifies code that displays collected percent values to use default of 100 if max is not set. This prevents crashes if max is not set and data has been collected, and is consistent with the default max value used on init of the empty format.

closes #1126

Change Type

  • ADDITION (non-breaking change that adds functionality)
  • CHANGE (fix or feature that alters existing functionality)
  • FIX (non-breaking change that resolves an issue)
  • OTHER (use only for changes like tooling, build system, CI, docs, etc.)

Release Note

Fixed a bug causing Field Book to crash if a percent trait was imported and used without min and max values

Release Type

For internal use - please leave these unchecked unless you are the one completing the merge.

  • MAJOR
  • MINOR
  • WAIT (No immediate release, but the changelog will be still be updated if there is a release note.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Fatal Exception in collect activity if using percent trait that was imported without min or max
2 participants