Fix bad alignment of compatibility highlighter popups in some cases

Phidica · Oct 27, 2019 · 0f7d31b · 0f7d31b
1 parent 217d825
commit 0f7d31b
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/highlighter_compat.py b/highlighter_compat.py
@@ -158,6 +158,13 @@ def on_hover(self, point, hover_zone):
         self.logger.error("Unknown change {} from issue {}".format(state['change'], issueID))
         continue
 
+      # In most cases, align popup to the first character of the region.
+      # However if the region is on a newline, popup must be one character back or it will draw on the wrong line
+      location = region.begin() + 1
+      regChar = self.view.substr( region.begin() )
+      if regChar == '\n':
+        location -= 1
+
       self.view.show_popup(
         """
           <body id = "compatibility_highlight">
@@ -188,7 +195,7 @@ def on_hover(self, point, hover_zone):
           </body>
         """.format(problem, self._fish_version(), issue['hint']),
         flags = sublime.HIDE_ON_MOUSE_MOVE_AWAY,
-        location = region.begin() + 1,
+        location = location,
       )
       break