Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1_18 and v1_19_R1 NMS update #83

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

q1445570795
Copy link

Add NMS v1_18_R1

@q1445570795
Copy link
Author

This is the first time I use GitHub to submit code, so I'm not very proficient :)

@apatuka
Copy link

apatuka commented Jun 15, 2022

@q1445570795 Planning to update this for 1.19 ?

@ghost
Copy link

ghost commented Jul 1, 2022

Hello,
Could you please provide your modification of the pom.xml file ?
Because as it is, it is impossible for someone else to compile your code.
Thanks in advance ! ^^

Just for compatibility with 1.18.2 and 1.19, no other changes!
@q1445570795 q1445570795 changed the title I updated it to MC1.18 support v1_18 and v1_19_R1 NMS update Jul 7, 2022
@q1445570795
Copy link
Author

q1445570795 commented Jul 7, 2022

@q1445570795 Planning to update this for 1.19 ?
@apatuka
I have added nms, of course you can download the compiled .jar file from my homepage

@q1445570795
Copy link
Author

@Sailoriae
Sorry, I didn't develop it by Maven.

Because the package and class names after version 1.17 are the same during my development, I can't compile,

Make 1.17, 1.18 and 1.19 unable to coexist):

I can only import one version package to compile

v1_ 18_ R1、v1_ 18_ R2、v1_ 19_ R1 cannot coexist. It must be deleted every time it is compiled, leaving only one

This method is stupid, just to make the plug-in available in the version

Can you understand me? My English is poor and I can't express it.

@ghost
Copy link

ghost commented Jul 7, 2022

Thank you for your answer. In fact, the problem is that the structure of the project and of the pom.xml needs to be reviewed so that we can continue to compile with Maven. For example, we should take a look at what the Citizens developers do.
https://github.com/CitizensDev/Citizens2

@q1445570795
Copy link
Author

About how I compile:
1.download Bukkit Files DragonTravel v01.008.02.jar
2.Compile NMS v1.18R1 v1.18R2 v1.19R1 one by one, generate jars, and only take v1_18_R1 and v1_18_R2 and v1_19_R1 class file
3.Open dragontravel v01.008.02 with WinRAR jar,
Path: \eu\phiwa\dragontravel\nms
Put the three compiled versions into it

@ghost
Copy link

ghost commented Jul 7, 2022

I see... There is a way to automated all of this with Maven. I will try to do it, but for the moment I don't have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants