Pool Stable: replaces Decimal with Decimal256 #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangov
force-pushed
the
feature/stable-pool-to-use-decimal256
branch
from
8018e66 to
58a4802
Compare
ueco-jb
reviewed
Aug 6, 2024
ueco-jb
reviewed
Aug 6, 2024
ueco-jb
reviewed
Aug 6, 2024
ueco-jb
reviewed
Aug 6, 2024
ueco-jb
reviewed
Aug 9, 2024
| ), | ||
| ], | ||
| ) | ||
| .to_u128() | ||
| .expect("Pool stable: provide_liquidity: conversion to u128 failed"); | ||
| .to_u128_with_precision(DECIMAL_PRECISION as i32); |
| .expect("Pool stable: provide_liquidity: conversion to u128 failed") | ||
| - initial_invariant, | ||
| ); | ||
| let invariant_delta = new_invariant - initial_invariant; |
Comment on lines
387
to
392
| (Decimal256::raw(U256::from_u128(&env, invariant_delta)).div( | ||
| &env, | ||
| Decimal256::raw(U256::from_u128(&env, initial_invariant)), | ||
| )) | ||
| .mul_u128(&env, convert_i128_to_u128(total_shares)) | ||
| .to_u128() |
There was a problem hiding this comment.
And this should later be converted to u128_with_precision (greatest_precision)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.