-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features as described in Issue 37 #51
Conversation
Hi @dmdhrumilmistry |
Sure. Sg! |
@dmdhrumilmistry Thanks for the PR. This looks very good. I tested it and everything works as expected. Quick question, any reason for using Also, when i run |
sg, actually tds are different flags
If you only need tlds then you'll need to use below command mantis list -td -o "sample-org" -a 2024-01-01 -b 2024-02-02 |
Makes sense. @Prateek-Thakare I tested the functionality. It's good to go. Can you go through the code and merge the PR? |
Hi @dmdhrumilmistry, Thanks, |
Hey @Prateek-Thakare, I've removed ansible files. LMK if any other changes are required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is structured well and @0xbharath has tested the flow end to end.
@Prateek-Thakare / @0xbharath thanks for the merge 🙌. Can someone add |
Thanks for the contribution. I have added the labels to the PRs. Looking forward to more such contributions. |
Add features as described in Issue 37
Issue Link: #37
Note
-a
/--after
and-b
/--before
filters can be used individually as wellChecklist: