-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Namecheap Nameserver integration #55
Conversation
This looks good but I got an error when testing this integration. What is the errorI ran mantis with your Namecheap extension but I got the following error.
Possible causesThis doesn't seem to be an issue with your code. I have two domains in my Namecheap account and this error happens when the the records are enumerated for a domain that uses external Nameserver. Possible resolution
|
@0xbharath I will test both these suggestions and update my PR. |
You can refer to this PR #53 |
@0xbharath This issue must be fixed when running mantis scan with -is or --in_scope flag. I completed adding this flag functionality into into the arg parser (arg_parse.py). Note: I only catch this error '2030288 - domain is not using proper DNS servers'. If I need to handle any others let me know. |
This should be good. I'll review this and let you know. |
This has been delayed on my end. Will review this today. |
This is good from a functionality PoV. @Prateek-Thakare Can you go through the code and merge this? |
Explicit installation is not needed for pip packages in the Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, Bharath has tested the code. Made changes to the files not needed.
Closes Issue #46
Tested using Namecheap sandbox API.