Implement the send() function for contracts #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgil-serbanuta
force-pushed
the
send
branch
from
186e16b to
1b43817
Compare
virgil-serbanuta
force-pushed
the
send
branch
from
1b43817 to
864e307
Compare
ACassimiro
reviewed
Sep 26, 2024
| @@ -28,7 +28,7 @@ module MX-RUST-MODULES-ADDRESS | |||
| ( struct | |||
| ( #token("ManagedAddress", "Identifier"):Identifier | |||
| , #token("mx_address_value", "Identifier"):Identifier |-> AddressValueId:Int | |||
| _:Map | |||
There was a problem hiding this comment.
Could you elaborate on a scenario where a non-empty map here should prevent the rewriting operation of rustValueToMx? This question is more for clarification purposes.
There was a problem hiding this comment.
This map should always be empty. Forcing an empty map here similar to an assertion - if we ever change the definition of the "ManagedAddress" to include more fields, this rule will fail to apply and we will have to update it.
ACassimiro
approved these changes
Sep 26, 2024
ACassimiro
added a commit
that referenced
this pull request
Sep 27, 2024
* Implement TokenIdentifier (#100) * Mutable variables (#105) * Update K to 149 (#99) (#101) Co-authored-by: Virgil <[email protected]> * Introducing mutable variables and preventing override on immutable ones * Adding minor comments * Update K to 149 (#99) (#104) Co-authored-by: Virgil <[email protected]> * Removing restrictions over reassignments of immutable variables * [Fix] Removing restrictions over reassignments of immutable variables * Addressing review comments --------- Co-authored-by: Virgil <[email protected]> * Implement the send() function for contracts (#102) * Enabling assignments on tuples with let expressions (#107) * Enabling assignments on tuples with let expressions * Addressing comments * Implement call_value() (#103) * BigUint operations (#106) --------- Co-authored-by: Virgil <[email protected]>
ACassimiro
added a commit
that referenced
this pull request
Sep 30, 2024
* Updating to match main (#109) * Implement TokenIdentifier (#100) * Mutable variables (#105) * Update K to 149 (#99) (#101) Co-authored-by: Virgil <[email protected]> * Introducing mutable variables and preventing override on immutable ones * Adding minor comments * Update K to 149 (#99) (#104) Co-authored-by: Virgil <[email protected]> * Removing restrictions over reassignments of immutable variables * [Fix] Removing restrictions over reassignments of immutable variables * Addressing review comments --------- Co-authored-by: Virgil <[email protected]> * Implement the send() function for contracts (#102) * Enabling assignments on tuples with let expressions (#107) * Enabling assignments on tuples with let expressions * Addressing comments * Implement call_value() (#103) * BigUint operations (#106) --------- Co-authored-by: Virgil <[email protected]> * Modifying pyk version * Modifying krun dir_paths to appropriate targets --------- Co-authored-by: Virgil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38