Bytes hooks #151
Merged
Bytes hooks #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgil-serbanuta
force-pushed
the
byte-hooks
branch
from
a20b0be to
25839cc
Compare
virgil-serbanuta
commented
Oct 8, 2024
| cat $(UKM_CONTRACTS_TESTING_INPUT_DIR)/bytes_hooks.rs >> [email protected] | ||
| echo ">)>" >> [email protected] | ||
|
|
||
| # echo "<(<" > [email protected] |
There was a problem hiding this comment.
I plan to uncomment this as soon as we can parse ukm.rs.
ACassimiro
reviewed
Oct 9, 2024
| <ukm-bytes-buffers> | ||
| M => M[NextId <- b""] | ||
| </ukm-bytes-buffers> | ||
| <ukm-bytes-next-id> |
There was a problem hiding this comment.
@virgil-serbanuta , Are we treating the bytes using a pseudo indexed-memory approach? Is that the purpose of <ukm-bytes-next-id> and <ukm-bytes-buffers>?
There was a problem hiding this comment.
I think so. This is a mapping from indexes to Bytes objects, with indexes generated sequentially from the <ukm-bytes-next-id> cell. It is sort of similar with a heap in which memory is never freed, and which holds only values of type Bytes.
There was a problem hiding this comment.
Thank you for the explanation, Virgil.
ACassimiro
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant for #135