Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty implementation for events #160

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Empty implementation for events #160

merged 1 commit into from
Oct 17, 2024

Conversation

virgil-serbanuta
Copy link
Member

@virgil-serbanuta virgil-serbanuta commented Oct 17, 2024 •
edited
Loading

Part of #161

@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review October 17, 2024 13:54
ACassimiro
ACassimiro approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@ACassimiro ACassimiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issues with this implementation. LGTM.

@virgil-serbanuta virgil-serbanuta merged commit 1956d71 into main Oct 17, 2024
3 checks passed
@virgil-serbanuta virgil-serbanuta deleted the events branch October 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ACassimiro ACassimiro ACassimiro approved these changes

@yanliu18 yanliu18 Awaiting requested review from yanliu18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgil-serbanuta @ACassimiro