Fix storage types #179
Merged
Fix storage types #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robertorosmaninho
approved these changes
Nov 5, 2024
ulm-semantics/main/hooks/bytes.md
Outdated
| @@ -345,6 +345,7 @@ module ULM-SEMANTICS-HOOKS-BYTES | |||
|
|
|||
| rule ulmBytesHash(ptrValue(_, u64(BytesId))) | |||
| => ulmBytesHash(ulmBytesId(BytesId)) | |||
| // TODO: use Keccack here. | |||
There was a problem hiding this comment.
Strictly speaking, we don't need keccack here. What we actually want is:
- A hash function that has a low collision probability
- Using all 256 bits of the hash.
It's just that we are already using keccack in other places so we wouldn't add new dependencies or complexity by using it.
There was a problem hiding this comment.
I rewrote the TODO.
virgil-serbanuta
force-pushed
the
storage-type
branch
from
f06babd to
63d4cea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.