Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name and symbol added to DAIMock #186

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

mariaKt
Copy link

@mariaKt mariaKt commented Nov 9, 2024

This PR adds the name and symbol methods to the DAIMock* contracts, and updates byol.py to print the result of these calls.

Tested for DAIMock.rs (with byol), the result is

Name:  Dai Stablecoin
Symbol:  DAI

@mariaKt mariaKt changed the title Name and cymbol added to DAIMock Name and symbol added to DAIMock Nov 9, 2024
Copy link

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Robertorosmaninho Robertorosmaninho merged commit 89bd0f8 into ulm-virgil Nov 9, 2024
2 of 3 checks passed
@Robertorosmaninho Robertorosmaninho deleted the ulm-dai-namesymbol branch November 9, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants