Contract calls #74
Contract calls #74
Conversation
virgil-serbanuta
force-pushed
the
calls
branch
from
c0d4b8f to
4ba654f
Compare
| imports STRING-SYNTAX | ||
|
|
||
| configuration | ||
| // TODO: The address should be bytes. |
There was a problem hiding this comment.
Is any operation involving the account address or the esdt-id based on properties that come from them being bytes? If this is just for representation, having them as a string or as integers (like it is done in KEVM) can be simpler to handle.
There was a problem hiding this comment.
Normally, the address is a hash value, represented as a sequence of 32 bytes. For our example, I think it's fine to leave it as a String, since it's easier to use in various contexts (e.g. tests), it's more interesting to use descriptive values for addresses, and it should be easy to convert it to bytes whenever we decide to do that.
| @@ -24,4 +24,11 @@ module MX-CALL-RESULT-CONFIGURATION | |||
| <mx-call-result> .MxCallResult </mx-call-result> | |||
| endmodule | |||
|
|
|||
| module MX-CALL-RETV-CONFIGURATION | |||
There was a problem hiding this comment.
This might be a nitpick, but I'd suggest being descriptive with the module names. Reading the module, I understand that RETV is supposed to mean "Return Values", but sounds more like an acronym.
Closes #52