Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mx-rust framework and storage implementation #80

Merged
merged 13 commits into from
Sep 11, 2024
Merged

Conversation

virgil-serbanuta
Copy link
Member

@virgil-serbanuta virgil-serbanuta commented Sep 10, 2024

Closes #54
Closes #45
Closes #33
Closes #26
Relevant to #36

@virgil-serbanuta virgil-serbanuta force-pushed the mx-rust-c branch 4 times, most recently from c812e88 to d4bd80f Compare September 11, 2024 09:22
Copy link
Collaborator

@ACassimiro ACassimiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've also tested locally and had no issues.

@virgil-serbanuta virgil-serbanuta merged commit 4eac1c1 into main Sep 11, 2024
1 check passed
@virgil-serbanuta virgil-serbanuta deleted the mx-rust-c branch September 11, 2024 19:20
ACassimiro added a commit that referenced this pull request Sep 11, 2024
* Arrange the cells for easier debugging

* Create a list of traits to help with mx preprocessing

* Static method calls

* Integer - value conversions

* Ignore generic args when casting structs

* Framework for executing Mx+Rust

* Framework for testing Mx+Rust

* Implement storage functions

* Implement storage accessors

* Implement BigUint::from

* Default storage values

* Storage set_if_empty

* Storage tests

---------

Co-authored-by: Virgil <[email protected]>
ACassimiro added a commit that referenced this pull request Sep 12, 2024
* Adding initial tests

* Removing usage of mut var

* Mx-rust framework and storage implementation (#80) (#81)

* Arrange the cells for easier debugging

* Create a list of traits to help with mx preprocessing

* Static method calls

* Integer - value conversions

* Ignore generic args when casting structs

* Framework for executing Mx+Rust

* Framework for testing Mx+Rust

* Implement storage functions

* Implement storage accessors

* Implement BigUint::from

* Default storage values

* Storage set_if_empty

* Storage tests

---------

Co-authored-by: Virgil <[email protected]>

* Implementing rules for evaluating conditionals and adding tests

* handling cases where the conditional is not the return

* Removing dead code

* Addressing PR comments and adding tests

* Adding test for function without return

---------

Co-authored-by: Virgil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants