If expressions #82
Merged
If expressions #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Arrange the cells for easier debugging * Create a list of traits to help with mx preprocessing * Static method calls * Integer - value conversions * Ignore generic args when casting structs * Framework for executing Mx+Rust * Framework for testing Mx+Rust * Implement storage functions * Implement storage accessors * Implement BigUint::from * Default storage values * Storage set_if_empty * Storage tests --------- Co-authored-by: Virgil <[email protected]>
|
Addresses #17 . |
virgil-serbanuta
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
you may want to make sure that these work before closing #17:
fn test_if1(&self) { // No return type
if true {
10u64
} else {
11u64
};
}
and
fn test_if2(&self) -> u64 {
if true {
10u64
} else {
11u64
};
11
}
| rule S:ExpressionWithBlock ; => S | ||
|
|
||
| rule (if ptrValue(_, true) S:BlockExpression):ExpressionWithBlock => S [owise] | ||
| rule (if ptrValue(_, false) _:BlockExpression):ExpressionWithBlock => . [owise] |
There was a problem hiding this comment.
I think that the standard is to use ".K" instead of ".". It also produces this warning:
[Warning] Compiler: Use of deprecated production found; this syntax may be
removed in the future.
Source(/mnt/data/pi-squared/rust-demo-semantics/rust-semantics/execution/conditionals.md)
Location(10,75,10,76)
10 | rule (if ptrValue(_, false) _:BlockExpression):ExpressionWithBlock =>
. [owise]
.
^
Comment on lines
9
to
13
| rule (if ptrValue(_, true) S:BlockExpression):ExpressionWithBlock => S [owise] | ||
| rule (if ptrValue(_, false) _:BlockExpression):ExpressionWithBlock => . [owise] | ||
|
|
||
| rule (if ptrValue(_, true) A:BlockExpression else _:IfElseExpression):ExpressionWithBlock => A | ||
| rule (if ptrValue(_, false) _:BlockExpression else B:IfElseExpression):ExpressionWithBlock => B |
There was a problem hiding this comment.
I think that the 4 rules above are actually part of expression evaluation.
| imports RUST-SHARED-SYNTAX | ||
| imports RUST-VALUE-SYNTAX | ||
|
|
||
| rule S:ExpressionWithBlock ; => S |
There was a problem hiding this comment.
This is not specific to if so I would put it in a different file (block-expressions.md maybe?)
|
Also addresses #30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing if expressions to our rust-lite semantics.