-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniswapv2librarygetreserves summary #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would just annotate the type of Ss
for the sake of documentation!
@Robertorosmaninho sure. Can you clarify where it is you want me to anotate? It is matched only when it is |
Yes, my idea was to have |
Alright. Since this is OK with you, I will leave it as is, because I prefer annotations in the LHS myself. |
This PR adds summaries for the body of the function
Uniswapv2librarygetreserves
.solidity-demo-semantics/test/examples/swaps/UniswapV2SwapRenamed.sol
Line 275 in 4fb604f
We stop before the call to
getReserves
, as it is through an unknown address.These summaries save 972 steps (22667 -> 21695).