Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniswapv2librarygetreserves summary #48

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

mariaKt
Copy link
Contributor

@mariaKt mariaKt commented Sep 27, 2024

This PR adds summaries for the body of the function Uniswapv2librarygetreserves.

function uniswapV2LibraryGetReserves(address tokenA, address tokenB) private returns (uint[] memory reserves) {

We stop before the call to getReserves, as it is through an unknown address.

These summaries save 972 steps (22667 -> 21695).

@mariaKt mariaKt requested review from Robertorosmaninho and dwightguth and removed request for dwightguth and Robertorosmaninho September 27, 2024 20:11
@mariaKt mariaKt requested a review from dwightguth September 28, 2024 21:39
Copy link
Contributor

@Robertorosmaninho Robertorosmaninho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would just annotate the type of Ss for the sake of documentation!

@mariaKt
Copy link
Contributor Author

mariaKt commented Sep 30, 2024

@Robertorosmaninho sure. Can you clarify where it is you want me to anotate? It is matched only when it is Statements in the <contract-fn-body> cell.

@Robertorosmaninho
Copy link
Contributor

@Robertorosmaninho sure. Can you clarify where it is you want me to anotate? It is matched only when it is Statements in the <contract-fn-body> cell.

Yes, my idea was to have Ss:Statements in the k cell too. But it's fine as it is as well!!

@mariaKt
Copy link
Contributor Author

mariaKt commented Sep 30, 2024

Alright. Since this is OK with you, I will leave it as is, because I prefer annotations in the LHS myself.

@mariaKt mariaKt merged commit c94634e into main Sep 30, 2024
1 check passed
@mariaKt mariaKt deleted the uniswapv2librarygetreserves-summary branch September 30, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants