Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC20 transfer test #53

Merged
merged 2 commits into from
Dec 20, 2024
Merged

ERC20 transfer test #53

merged 2 commits into from
Dec 20, 2024

Conversation

virgil-serbanuta
Copy link
Member

No description provided.

Co-authored-by: Traian Florin Șerbănuță <[email protected]>
Co-authored-by: Virgil Șerbănuță <[email protected]>
@virgil-serbanuta virgil-serbanuta force-pushed the erc20_tests_following_rust branch from d67b793 to 344d2af Compare December 19, 2024 19:31
@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review December 19, 2024 19:33
Copy link

@sskeirik sskeirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

I wanted to leave a comment on a possible future twist on this approach (no need to try and implement this now): if we can't get strictness added to alternate cells, there is an alternate approach that might make the code a bit cleaner.

Essentially, the idea is to have operators like:

syntax KItem ::= seqExp(List)
               | seqVal(List)

which is used to do all seq-strict style heating and cooling. Then the other operators desugar into it. For one argument operators, we have:

rule <k> (.K => seqExp(ListItem(Expr))) ~> #setOutput(Expr)
rule <k> seqVal(Expr) ~> #setOutput(_) => ... </k>

For many argument operators, we have:

rule (.K => seqExp(ListItem(E1) ListItem(E2) ListItem(E3) ListItem(E4)) ~> #log(E1, E2, E3, E4) </k>
rule seqVal(V1, V2, V3, V4) ~> #log(...) => ... </k>

Then, you only need to implement this strategy once.

@traiansf traiansf merged commit 3b0a7fa into master Dec 20, 2024
2 checks passed
@traiansf traiansf deleted the erc20_tests_following_rust branch December 20, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants