Added negative tests #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sskeirik
approved these changes
Dec 20, 2024
pykwasm/src/pykwasm/call.py
Outdated
Comment on lines
110
to
112
| except ContractLogicError as e: | ||
| print(f'Contract logic error: {e.message}', file=sys.stderr) | ||
| sys.exit(1) |
There was a problem hiding this comment.
This is the right logic, but I have a slight preference to put it in the if/then/else statement above since it shares the same logic by:
- adding the
ContractLogicErrorto the tuple of caught errors and; - adding a new case to the if/then/else statement for printing its message
| assert_eq "1000" "$supply" "Total Supply" | ||
|
|
||
| echo -e -n "\nTransfer too much test (should fail): " | ||
| erc20_transfer $k2 $contract $a3 $(to_hex 600) || true # this should fail |
There was a problem hiding this comment.
It might be nice to fail here if the call passes (my understanding is the call will always be considering passing with || true appended) --- though it should not be possible for the call to pass here and for the remaining calls to still pass.
The same holds true for the other negative case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.