Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants for WASM parsing and sample counter contract #56

Merged
merged 9 commits into from
Jan 14, 2025

Conversation

virgil-serbanuta
Copy link
Member

No description provided.

@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review January 9, 2025 13:53
Copy link

@sskeirik sskeirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this work! I found a couple minor typos (many of them my own) and I added suggestions for all of them, I believe. Anyway, could you double-check my suggested edits and see that you agree? Thanks!

pykwasm/src/pykwasm/kdist/wasm-semantics/binary-parser.md Outdated Show resolved Hide resolved
pykwasm/src/pykwasm/kdist/wasm-semantics/binary-parser.md Outdated Show resolved Hide resolved
pykwasm/src/pykwasm/kdist/wasm-semantics/binary-parser.md Outdated Show resolved Hide resolved
tests/ulm/counter/rust/README.md Outdated Show resolved Hide resolved
This file defines a Wasm binary parser based on this
[spec](https://webassembly.github.io/spec/core/binary/index.html).
To begin, we define constant macros which drive the parser process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```k
Maybe this would work
```

@virgil-serbanuta virgil-serbanuta merged commit 7f0a0dd into master Jan 14, 2025
3 checks passed
@virgil-serbanuta virgil-serbanuta deleted the ulm_upstream_test branch January 14, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants