Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pathing_manager set map callback should not dereference the value #45

Open
1 task
griswaldbrooks opened this issue Oct 25, 2023 · 0 comments
Open
1 task

Comments

@griswaldbrooks
Copy link
Collaborator

Need

In order to allow the unhappy path lambdas to have their natural return types
As a pathing manager
I want to pass in the assignment to the success branch rather than dereferencing.

Acceptance Criteria

Scenario: set map callback in pathing manager should set response in a lambda
GIVEN set map callback in pathing manager is running
WHEN the happy path succeeds
THEN the response message should be set in a lambda given to and_then
AND the unhappy path should have return paths that don't force a SetMap::Response when then don't need it.

Tasks

  • Refactor the below lines

Notes

pathing_manager set map callback should not dereference the expected
https://github.com/PickNikRobotics/ros_testing_templates/blob/ros2/functional_programming_tests/src/pathing_manager.cpp#L52-L57

This forces the or_else clauses to have a particular return type, which doesn't make sense in context.
References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant