Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Error Prone 2.10.0 -> 2.27.0 #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Apr 17, 2022

This PR contains the following updates:

Package Type Update Change
Error Prone (source) minor 2.10.0 -> 2.27.0
Error Prone (source) compile minor 2.10.0 -> 2.27.0

Release Notes

google/error-prone (Error Prone)

v2.27.0: Error Prone 2.27.0

Compare Source

New checks:

  • ClassInitializationDeadlock detects class initializers that reference subtypes of the current class, which can result in deadlocks.
  • MockitoDoSetup suggests using when/thenReturn over doReturn/when for additional type safety.
  • VoidUsed suggests using a literal null instead of referring to a Void-typed variable.

Modified checks:

Closed issues: #​4291. #​4308, #​4343, #​4320

Full Changelog: google/error-prone@v2.26.1...v2.27.0

v2.26.1: Error Prone 2.26.1

Compare Source

This release contains all of the changes in 2.26.0, plus a bug fix to the module name of the annotations artifact com.google.errorprone.annotations (google/error-prone@9d99ee7)

Starting in 2.26.x, the 'annotations' artifact now includes a module-info.java for Java Platform Module System support, thanks to @​sgammon in #​4311.


Compatibility note:

Now that the annotations artifact explicit declares a module instead of relying on Automatic-Module-Name, JDK 17 and newer perform stricter module encapsulation checks. Modularized libraries depending on Error Prone annotations 2.26.x and newer may see errors like:

error: package com.google.errorprone.annotations is not visible
import com.google.errorprone.annotations.CheckReturnValue;
                            ^
  (package com.google.errorprone.annotations is declared in module com.google.errorprone.annotations, but module ... does not read it)

The fix is to add requires static to the module declaration of modularized libraries that depend on Error Prone annotations:

 module your.module {
...
+  requires static com.google.errorprone.annotations;
 }

Full Changelog: google/error-prone@v2.26.0...v2.26.1

v2.26.0: Error Prone 2.26.0

Compare Source

Warning: This release contains a bug, please use 2.26.1 or newer instead.

Changes:

  • The 'annotations' artifact now includes a module-info.java for Java Platform Module System support, thanks to @​sgammon in #​4311.
  • Disabled checks passed to -XepPatchChecks are now ignored, instead of causing a crash. Thanks to @​oxkitsune in #​4028.

New checks:

  • SystemConsoleNull: Null-checking System.console() is not a reliable way to detect if the console is connected to a terminal.
  • EnumOrdinal: Discourage uses of Enum.ordinal()

Closed issues: #​2649, #​3908, #​4028, #​4311, #​4314

Full Changelog: google/error-prone@v2.25.0...v2.26.0

v2.25.0: Error Prone 2.25.0

Compare Source

New checks:

Closed issues: #​4195, #​4224, #​4228, #​4248, #​4249, #​4251

Full Changelog: google/error-prone@v2.24.1...v2.25.0

v2.24.1: Error Prone 2.24.1

Compare Source

Changes:

Full Changelog: google/error-prone@v2.24.0...v2.24.1

v2.24.0: Error Prone 2.24.0

Compare Source

New checks:

Full Changelog: google/error-prone@v2.23.0...v2.24.0

v2.23.0: Error Prone 2.23.0

Compare Source

New checks:

Bug fixes and improvements: #​3897, #​4114, #​4123

Full Changelog: google/error-prone@v2.22.0...v2.23.0

v2.22.0: Error Prone 2.22.0

Compare Source

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #​3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #​3803.

New checks:

Bug fixes and improvements:

  • Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
  • Prevent SuggestedFixes#renameMethod from modifying return type declaration (#​4043)
  • Fix UnusedVariable false positives for private record parameters (#​2713)
  • When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#​2910)
  • CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#​4009)
  • UnusedVariable: exclude junit5's @RegisterExtension (#​3892)
  • Support running all available patch checks (#​947)
  • Upgrade java-diff-utils 4.0 -> 4.12 (#​4081)
  • Flag unused Refaster template parameters (#​4060)
  • Support @SuppressWarnings("all") (#​4065)
  • Prevent Refaster UMemberSelect from matching method parameters (#​2456)
  • MissingDefault : Don't require // fall out comments on expression switches (#​2709)
  • Skip UnnecessaryLambda findings for usages in enhanced for loops (#​2518)
  • Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#​3797)
  • Add support for specifying exemptPrefixes/exemptNames for UnusedVariable via flags (#​2753)
  • UnusedMethod: Added exempting variable annotations (#​2881)

Full Changelog: google/error-prone@v2.21.1...v2.22.0

v2.21.1: Error Prone 2.21.1

Compare Source

Changes:

  • Handle overlapping ranges in suppressedRegions (fixes #​4040)
  • Add AddressSelection to discourage APIs that convert a hostname to a single address

Full Changelog: google/error-prone@v2.21.0...v2.21.1

v2.21.0: Error Prone 2.21.0

Compare Source

New Checkers:

Fixed issues: #​3976, #​3986, #​4001, #​4002, #​4026, #​4027

Full Changelog: google/error-prone@v2.20.0...v2.21.0

v2.20.0: Error Prone 2.20.0

Compare Source

Changes:

  • This release is compatible with early-access builds of JDK 21.

New Checkers:

Fixes issues: #​2232, #​2243, #​2997, #​3301, #​3843, #​3903, #​3918, #​3923, #​3931, #​3945, #​3946

Full Changelog: google/error-prone@v2.19.1...v2.20.0

v2.19.1: Error Prone 2.19.1

Compare Source

This release fixes a binary compatibility issue when running on JDK 11, see #​3895

Full Changelog: google/error-prone@v2.19.0...v2.19.1

v2.19.0: Error Prone 2.19.0

Compare Source

New Checkers:

Fixes issues: #​956, #​3504, #​3654, #​3703, #​3731, #​3737, #​3760, #​3779, #​3796, #​3809, #​3813

Full Changelog: google/error-prone@v2.18.0...v2.19.0

v2.18.0: Error Prone 2.18.0

Compare Source

New Checkers:

Fixes issues: #​1650, #​2706, #​3404, #​3493, #​3504, #​3519, #​3579, #​3610, #​3632, #​3638, #​3645, #​3646, #​3652, #​3690

Full Changelog: google/error-prone@v2.17.0...v2.18.0

v2.17.0: Error Prone 2.17.0

Compare Source

New Checkers:

Fixed issues: #​2321, #​3144, #​3297, #​3428, #​3437, #​3462, #​3482, #​3494

Full Changelog: google/error-prone@v2.16...v2.17.0

v2.16: Error Prone 2.16.0

Compare Source

New Checkers:

Fixed issues: #​3092, #​3220, #​3225, #​3267, #​3441

Full Changelog: google/error-prone@v2.15.0...v2.16

v2.15.0: Error Prone 2.15.0

Compare Source

New Checkers:

Fixed issues: #​1562, #​3236, #​3245, #​3321

Full Changelog: google/error-prone@v2.14.0...v2.15.0

v2.14.0: Error Prone 2.14.0

Compare Source

New checkers:

Fixed issues: #​3110, #​3193

Full Changelog: google/error-prone@v2.13.1...v2.14.0

v2.13.1: Error Prone 2.13.1

Compare Source

What's Changed

Full Changelog: google/error-prone@v2.13.0...v2.13.1

v2.13.0: Error Prone 2.13.0

Compare Source

  • Handle all annotations with the simple name Generated in -XepDisableWarningsInGeneratedCode (#​3094)
  • Reconcile BugChecker#isSuppressed with suppression handling in ErrorProneScanner (#​3094)
  • Fix a bug in enclosingPackage (8fa64d4)
  • Improve performance of fix application (186334b)
  • Implicitly treat @AutoBuilder setter methods as @CanIgnoreReturnValue.
  • Remove some obsolete checks (PublicConstructorForAbstractClass, HashCodeToString)

Release Diff: v2.12.1...v2.13.0.

v2.12.1: Error Prone 2.12.1

Compare Source

v2.12.0: Error Prone 2.12.0

Compare Source

New checks

Fixed issues: #​58, #​65, #​1327, #​1654, #​2858, #​2867, #​2916, #​2951, #​2954, #​3006, #​3008

Full Changelog: google/error-prone@v2.11.0...v2.12.0

v2.11.0: Error Prone 2.11.0

Compare Source

Error Prone now requires JDK 11 or newer (https://github.com/google/error-prone/issues/2730).

New checks

Fixed issues: #​2641, #​2705, #​2776, #​2798, #​2799, #​2819, #​2820, #​2831, #​2833, #​2834, #​2835, #​2861, #​2873, #​2889, #​2892, #​2901

Full Changelog: google/error-prone@v2.10.0...v2.11.0


  • If you want to rebase/retry this PR, check this box

@Picnic-Bot Picnic-Bot added the dependencies Pull requests that update a dependency file label Apr 17, 2022
@Picnic-Bot
Copy link
Contributor Author

Picnic-Bot commented Apr 17, 2022

Suggested commit message:

Upgrade Error Prone 2.10.0 -> 2.27.0

See:
- https://github.com/google/error-prone/releases/tag/v2.11.0
- https://github.com/google/error-prone/releases/tag/v2.12.0
- https://github.com/google/error-prone/releases/tag/v2.12.1
- https://github.com/google/error-prone/releases/tag/v2.13.0
- https://github.com/google/error-prone/releases/tag/v2.13.1
- https://github.com/google/error-prone/releases/tag/v2.14.0
- https://github.com/google/error-prone/releases/tag/v2.15.0
- https://github.com/google/error-prone/releases/tag/v2.16
- https://github.com/google/error-prone/releases/tag/v2.17.0
- https://github.com/google/error-prone/releases/tag/v2.18.0
- https://github.com/google/error-prone/releases/tag/v2.19.0
- https://github.com/google/error-prone/releases/tag/v2.19.1
- https://github.com/google/error-prone/releases/tag/v2.20.0
- https://github.com/google/error-prone/releases/tag/v2.21.0
- https://github.com/google/error-prone/releases/tag/v2.21.1
- https://github.com/google/error-prone/releases/tag/v2.22.0
- https://github.com/google/error-prone/releases/tag/v2.23.0
- https://github.com/google/error-prone/releases/tag/v2.24.0
- https://github.com/google/error-prone/releases/tag/v2.24.1
- https://github.com/google/error-prone/releases/tag/v2.25.0
- https://github.com/google/error-prone/releases/tag/v2.26.0
- https://github.com/google/error-prone/releases/tag/v2.26.1
- https://github.com/google/error-prone/releases/tag/v2.27.0
- https://github.com/google/error-prone/compare/v2.10.0...v2.27.0

Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to first pick up the simplification discussed here. Additionally we should wait for a release of mockito/mockito#2608.

@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch 3 times, most recently from ec6e0e9 to ba4545c Compare April 24, 2022 21:01
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.13.1 Upgrade version.error-prone 2.10.0 -> 2.13.1 - autoclosed May 19, 2022
@Picnic-Bot Picnic-Bot closed this May 19, 2022
@Picnic-Bot Picnic-Bot deleted the renovate/version.error-prone branch May 19, 2022 21:01
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.13.1 - autoclosed Upgrade version.error-prone 2.10.0 -> 2.13.1 May 25, 2022
@Picnic-Bot Picnic-Bot restored the renovate/version.error-prone branch May 25, 2022 21:01
@Picnic-Bot Picnic-Bot reopened this May 25, 2022
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.13.1 Upgrade version.error-prone 2.10.0 -> 2.14.0 May 26, 2022
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch 2 times, most recently from 1942637 to 0cffbe3 Compare May 31, 2022 21:01
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch from 0cffbe3 to d2a30e0 Compare June 9, 2022 21:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch from d2a30e0 to a0cb262 Compare July 10, 2022 21:03
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.14.0 Upgrade version.error-prone Aug 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone Upgrade version.error-prone 2.10.0 -> 2.15.0 Aug 7, 2022
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.15.0 Upgrade version.error-prone Oct 11, 2022
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone Upgrade version.error-prone 2.10.0 -> 2.16 Oct 12, 2022
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.17.0 Upgrade version.error-prone 2.10.0 -> 2.18.0 Jan 10, 2023
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch from 16b40d5 to 30f14e6 Compare May 9, 2023 22:01
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.18.0 Upgrade version.error-prone 2.10.0 -> 2.19.0 May 9, 2023
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch from 30f14e6 to 160284a Compare May 11, 2023 22:03
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.19.0 Upgrade version.error-prone 2.10.0 -> 2.19.1 May 11, 2023
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.19.1 Upgrade version.error-prone 2.10.0 -> 2.20.0 Jun 19, 2023
@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch from 160284a to f4583ba Compare June 19, 2023 22:11
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.20.0 Upgrade version.error-prone 2.10.0 -> 2.21.0 Aug 2, 2023
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.21.0 Upgrade version.error-prone 2.10.0 -> 2.21.1 Aug 6, 2023
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.21.1 Upgrade version.error-prone 2.10.0 -> 2.22.0 Sep 21, 2023
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.22.0 Upgrade version.error-prone 2.10.0 -> 2.23.0 Oct 19, 2023
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.23.0 Upgrade version.error-prone 2.10.0 -> 2.24.0 Dec 24, 2023
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.24.0 Upgrade version.error-prone 2.10.0 -> 2.24.1 Jan 3, 2024
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.24.1 Upgrade version.error-prone 2.10.0 -> 2.25.0 Feb 18, 2024
@Picnic-Bot Picnic-Bot changed the title Upgrade version.error-prone 2.10.0 -> 2.25.0 Upgrade Error Prone 2.10.0 -> 2.25.0 Feb 27, 2024
@Picnic-Bot Picnic-Bot changed the title Upgrade Error Prone 2.10.0 -> 2.25.0 Upgrade Error Prone 2.10.0 -> 2.26.0 Mar 11, 2024
@Picnic-Bot Picnic-Bot changed the title Upgrade Error Prone 2.10.0 -> 2.26.0 Upgrade Error Prone 2.10.0 -> 2.26.1 Mar 13, 2024
@Picnic-Bot Picnic-Bot changed the title Upgrade Error Prone 2.10.0 -> 2.26.1 Upgrade Error Prone 2.10.0 -> 2.27.0 Apr 28, 2024
@Picnic-Bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

2 participants