-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Error Prone 2.10.0 -> 2.27.0 #205
base: master
Are you sure you want to change the base?
Conversation
Suggested commit message:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to first pick up the simplification discussed here. Additionally we should wait for a release of mockito/mockito#2608.
ec6e0e9
to
ba4545c
Compare
ba4545c
to
ead3c13
Compare
1942637
to
0cffbe3
Compare
0cffbe3
to
d2a30e0
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
d2a30e0
to
a0cb262
Compare
a0cb262
to
8850ded
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
8850ded
to
981d0d2
Compare
981d0d2
to
9167919
Compare
16b40d5
to
30f14e6
Compare
30f14e6
to
160284a
Compare
160284a
to
f4583ba
Compare
f4583ba
to
a193f8c
Compare
a193f8c
to
d42a0f1
Compare
d42a0f1
to
b75dacd
Compare
b75dacd
to
85cb91b
Compare
85cb91b
to
dd9a972
Compare
dd9a972
to
3755a30
Compare
3755a30
to
50ac659
Compare
50ac659
to
ca3ae0f
Compare
ca3ae0f
to
3ab0a04
Compare
See: - https://github.com/google/error-prone/releases/tag/v2.27.0 - https://github.com/google/error-prone/releases/tag/v2.26.1 - https://github.com/google/error-prone/releases/tag/v2.26.0 - https://github.com/google/error-prone/releases/tag/v2.25.0 - https://github.com/google/error-prone/releases/tag/v2.24.1 - https://github.com/google/error-prone/releases/tag/v2.24.0 - https://github.com/google/error-prone/releases/tag/v2.23.0 - https://github.com/google/error-prone/releases/tag/v2.22.0 - https://github.com/google/error-prone/releases/tag/v2.21.1 - https://github.com/google/error-prone/releases/tag/v2.21.0 - https://github.com/google/error-prone/releases/tag/v2.20.0 - https://github.com/google/error-prone/releases/tag/v2.19.1 - https://github.com/google/error-prone/releases/tag/v2.19.0 - https://github.com/google/error-prone/releases/tag/v2.18.0 - https://github.com/google/error-prone/releases/tag/v2.17.0 - https://github.com/google/error-prone/releases/tag/v2.16 - https://github.com/google/error-prone/releases/tag/v2.15.0 - https://github.com/google/error-prone/releases/tag/v2.14.0 - https://github.com/google/error-prone/releases/tag/v2.13.1 - https://github.com/google/error-prone/releases/tag/v2.13.0 - https://github.com/google/error-prone/releases/tag/v2.12.1 - https://github.com/google/error-prone/releases/tag/v2.12.0 - https://github.com/google/error-prone/releases/tag/v2.11.0
3ab0a04
to
c5549ef
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
This PR contains the following updates:
2.10.0
->2.27.0
2.10.0
->2.27.0
Release Notes
google/error-prone (Error Prone)
v2.27.0
: Error Prone 2.27.0Compare Source
New checks:
ClassInitializationDeadlock
detects class initializers that reference subtypes of the current class, which can result in deadlocks.MockitoDoSetup
suggests usingwhen
/thenReturn
overdoReturn
/when
for additional type safety.VoidUsed
suggests using a literalnull
instead of referring to aVoid
-typed variable.Modified checks:
TruthSelfEquals
has been renamed and generalized asSelfAssertion
RedundantSetterCall
has been improved, and enabled as an error oby defaultClosed issues: #4291. #4308, #4343, #4320
Full Changelog: google/error-prone@v2.26.1...v2.27.0
v2.26.1
: Error Prone 2.26.1Compare Source
This release contains all of the changes in 2.26.0, plus a bug fix to the module name of the annotations artifact
com.google.errorprone.annotations
(google/error-prone@9d99ee7)Starting in
2.26.x
, the 'annotations' artifact now includes amodule-info.java
for Java Platform Module System support, thanks to @sgammon in #4311.Compatibility note:
Now that the annotations artifact explicit declares a module instead of relying on
Automatic-Module-Name
, JDK 17 and newer perform stricter module encapsulation checks. Modularized libraries depending on Error Prone annotations2.26.x
and newer may see errors like:The fix is to add
requires static
to the module declaration of modularized libraries that depend on Error Prone annotations:module your.module { ... + requires static com.google.errorprone.annotations; }
Full Changelog: google/error-prone@v2.26.0...v2.26.1
v2.26.0
: Error Prone 2.26.0Compare Source
Warning: This release contains a bug, please use 2.26.1 or newer instead.
Changes:
module-info.java
for Java Platform Module System support, thanks to @sgammon in #4311.-XepPatchChecks
are now ignored, instead of causing a crash. Thanks to @oxkitsune in #4028.New checks:
SystemConsoleNull
: Null-checkingSystem.console()
is not a reliable way to detect if the console is connected to a terminal.EnumOrdinal
: Discourage uses ofEnum.ordinal()
Closed issues: #2649, #3908, #4028, #4311, #4314
Full Changelog: google/error-prone@v2.25.0...v2.26.0
v2.25.0
: Error Prone 2.25.0Compare Source
New checks:
JUnitIncompatibleType
: Detects incompatible types passed to an assertion, similar toTruthIncompatibleType
RedundantSetterCall
: Detects fields set twice in the same chained expression. Generalization of previousProtoRedundantSet
check to also handle AutoValue.Closed issues: #4195, #4224, #4228, #4248, #4249, #4251
Full Changelog: google/error-prone@v2.24.1...v2.25.0
v2.24.1
: Error Prone 2.24.1Compare Source
Changes:
Full Changelog: google/error-prone@v2.24.0...v2.24.1
v2.24.0
: Error Prone 2.24.0Compare Source
New checks:
MultipleNullnessAnnotations
: Discourage multiple nullness annotationsNullableTypeParameter
: Discourage nullness annotations on type parametersNullableWildcard
: Discourage nullness annotations on wildcardsSuperCallToObjectMethod
: Generalization ofSuperEqualsIsObjectEquals
, now covershashCode
Full Changelog: google/error-prone@v2.23.0...v2.24.0
v2.23.0
: Error Prone 2.23.0Compare Source
New checks:
DuplicateDateFormatField
NonFinalStaticField
StringCharset
StringFormatWithLiteral
SuperEqualsIsObjectEquals
Bug fixes and improvements: #3897, #4114, #4123
Full Changelog: google/error-prone@v2.22.0...v2.23.0
v2.22.0
: Error Prone 2.22.0Compare Source
We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass
--release 11
to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #3803.New checks:
ClosingStandardOutputStreams
: Prevents accidentally closingSystem.{out,err}
with try-with-resourcesTruthContainsExactlyElementsInUsage
:containsExactly
is preferred overcontainsExactlyElementsIn
when creating new iterablesUnnecessaryAsync
: detects unnecessary use of async primitives in local (and hence single-threaded) scopesReturnAtTheEndOfVoidFunction
: detects unnecessaryreturn
statements at the end ofvoid
functionsMultimapKeys
: Suggests usingkeySet()
instead of iterating overMultimap.keys()
, which does not collapse duplicatesBug fixes and improvements:
AddressSelection
(google/error-prone@44b6552)Map.get
, etc. returnnull
(#2910)@RegisterExtension
(#3892)@SuppressWarnings("all")
(#4065)UMemberSelect
from matching method parameters (#2456)// fall out
comments on expression switches (#2709)exemptPrefixes
/exemptNames
for UnusedVariable via flags (#2753)Full Changelog: google/error-prone@v2.21.1...v2.22.0
v2.21.1
: Error Prone 2.21.1Compare Source
Changes:
AddressSelection
to discourage APIs that convert a hostname to a single addressFull Changelog: google/error-prone@v2.21.0...v2.21.1
v2.21.0
: Error Prone 2.21.0Compare Source
New Checkers:
AttemptedNegativeZero
: Prevents accidental use of-0
, which is the same as0
. The floating-point negative zero is-0.0
.ICCProfileGetInstance
: Warns on uses ofICC_Profile.getInstance(String)
, due to JDK-8191622.MutableGuiceModule
: Fields in Guice modules should befinal
.NullableOptional
: Discourages@Nullable
-annotatedOptional
s.OverridingMethodInconsistentArgumentNamesChecker
: Arguments of overriding method are inconsistent with overridden method.Fixed issues: #3976, #3986, #4001, #4002, #4026, #4027
Full Changelog: google/error-prone@v2.20.0...v2.21.0
v2.20.0
: Error Prone 2.20.0Compare Source
Changes:
New Checkers:
InlineTrivialConstant
UnnecessaryStringBuilder
BanClassLoader
DereferenceWithNullBranch
DoNotUseRuleChain
LockOnNonEnclosingClassLiteral
MissingRefasterAnnotation
NamedLikeContextualKeyword
NonApiType
Fixes issues: #2232, #2243, #2997, #3301, #3843, #3903, #3918, #3923, #3931, #3945, #3946
Full Changelog: google/error-prone@v2.19.1...v2.20.0
v2.19.1
: Error Prone 2.19.1Compare Source
This release fixes a binary compatibility issue when running on JDK 11, see #3895
Full Changelog: google/error-prone@v2.19.0...v2.19.1
v2.19.0
: Error Prone 2.19.0Compare Source
New Checkers:
NotJavadoc
StringCaseLocaleUsage
UnnecessaryTestMethodPrefix
Fixes issues: #956, #3504, #3654, #3703, #3731, #3737, #3760, #3779, #3796, #3809, #3813
Full Changelog: google/error-prone@v2.18.0...v2.19.0
v2.18.0
: Error Prone 2.18.0Compare Source
New Checkers:
InjectOnBugCheckers
LabelledBreakTarget
UnusedLabel
YodaCondition
Fixes issues: #1650, #2706, #3404, #3493, #3504, #3519, #3579, #3610, #3632, #3638, #3645, #3646, #3652, #3690
Full Changelog: google/error-prone@v2.17.0...v2.18.0
v2.17.0
: Error Prone 2.17.0Compare Source
New Checkers:
AvoidObjectArrays
Finalize
IgnoredPureGetter
ImpossibleNullComparison
MathAbsoluteNegative
NewFileSystem
StatementSwitchToExpressionSwitch
UnqualifiedYield
Fixed issues: #2321, #3144, #3297, #3428, #3437, #3462, #3482, #3494
Full Changelog: google/error-prone@v2.16...v2.17.0
v2.16
: Error Prone 2.16.0Compare Source
New Checkers:
ASTHelpersSuggestions
CanIgnoreReturnValueSuggester
LenientFormatStringValidation
UnnecessarilyUsedValue
Fixed issues: #3092, #3220, #3225, #3267, #3441
Full Changelog: google/error-prone@v2.15.0...v2.16
v2.15.0
: Error Prone 2.15.0Compare Source
New Checkers:
BuilderReturnThis
CanIgnoreReturnValueSuggester
CannotMockFinalClass
CannotMockFinalMethod
DirectInvocationOnMock
ExtendsObject
MockNotUsedInProduction
NoCanIgnoreReturnValueOnClasses
NullArgumentForNonNullParameter
SelfAlwaysReturnsThis
UnsafeWildcard
UnusedTypeParameter
Fixed issues: #1562, #3236, #3245, #3321
Full Changelog: google/error-prone@v2.14.0...v2.15.0
v2.14.0
: Error Prone 2.14.0Compare Source
New checkers:
BanJNDI
EmptyTopLevelDeclaration
ErroneousBitwiseExpression
FuzzyEqualsShouldNotBeUsedInEqualsMethod
Interruption
NullableOnContainingClass
Fixed issues: #3110, #3193
Full Changelog: google/error-prone@v2.13.1...v2.14.0
v2.13.1
: Error Prone 2.13.1Compare Source
What's Changed
UnnecessaryBoxedVariable
in https://github.com/google/error-prone/pull/3118Full Changelog: google/error-prone@v2.13.0...v2.13.1
v2.13.0
: Error Prone 2.13.0Compare Source
Generated
in-XepDisableWarningsInGeneratedCode
(#3094)BugChecker#isSuppressed
with suppression handling inErrorProneScanner
(#3094)enclosingPackage
(8fa64d4
)186334b
)@AutoBuilder
setter methods as@CanIgnoreReturnValue
.PublicConstructorForAbstractClass
,HashCodeToString
)Release Diff: v2.12.1...v2.13.0.
v2.12.1
: Error Prone 2.12.1Compare Source
This release adds an infrastructure optimization to
AppliedFix
source code processing.Release Diff: v2.12.0...v2.12.1.
v2.12.0
: Error Prone 2.12.0Compare Source
New checks
BoxedPrimitiveEquality
DoubleBraceInitialization
IgnoredPureGetter
LockOnBoxedPrimitive
IncorrectMainMethod
LongDoubleConversion
RobolectricShadowDirectlyOn
StaticAssignmentOfThrowable
UnnecessaryLongToIntConversion
Varifier
Fixed issues: #58, #65, #1327, #1654, #2858, #2867, #2916, #2951, #2954, #3006, #3008
Full Changelog: google/error-prone@v2.11.0...v2.12.0
v2.11.0
: Error Prone 2.11.0Compare Source
Error Prone now requires JDK 11 or newer (https://github.com/google/error-prone/issues/2730).
New checks
AutoValueBuilderDefaultsInConstructor
FloggerLogString
UnicodeDirectionalityCharacters
UnicodeInCode
AlreadyChecked
BugPatternNaming
MissingImplementsComparable
NegativeCharLiteral
PreferredInterfaceType
StronglyTypeByteString
UsingJsr305CheckReturnValue
Fixed issues: #2641, #2705, #2776, #2798, #2799, #2819, #2820, #2831, #2833, #2834, #2835, #2861, #2873, #2889, #2892, #2901
Full Changelog: google/error-prone@v2.10.0...v2.11.0