ci: split CI pull jobs

[wuhuizuo]

No description provided.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request: ci: split CI pull jobs

Key Changes:

1. The original .github/workflows/ci.yaml has been removed.
2. Four new GitHub Actions workflows have been created, each with specific triggering paths:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-product-runtime-base-images.yaml
3. A new Justfile has been added.
4. The dockerfiles-multi-stages/tikv/Dockerfile has been deleted.
5. A new dockerfiles/cd/tikv/tikv/Dockerfile has been added.

Potential Problems

1. The PR description is empty. It would be helpful to provide a brief explanation of the changes and the motivation behind splitting the CI jobs.
2. The removal of the original ci.yaml file means that any existing dependencies on this file will need to be updated to reflect the new workflow files.
3. The new workflows have been split into specific triggering paths, which can improve performance and organization. However, it may also increase the complexity of managing and maintaining the CI pipeline.

Fixing Suggestions:

1. Add a brief description to the PR explaining the changes and the motivation behind splitting the CI jobs.
2. Ensure that any dependencies on the original ci.yaml file are updated to reflect the new workflow files.
3. Monitor the new workflows and evaluate their performance and maintainability over time. If necessary, consider consolidating or further splitting the jobs to optimize the CI pipeline.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of Changes

This pull request splits CI pull jobs into different workflows by adding new YAML files and modifying the existing .github/workflows/ci.yaml. Here's a summary of the key changes:

1. Deleted the .github/workflows/ci.yaml file.
2. Added the following new YAML files:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Renamed the Dockerfile for Tiflash from dockerfiles/ci/release-build-base/tiflash/Dockerfile to dockerfiles/cd/pingcap/tiflash/Dockerfile and made some changes.
4. Added skaffold configuration files for the new CI/CD workflows.
5. Updated Justfile with new build steps.

Potential Problems and Fixes

1. There is no PR description, which makes it difficult to understand the context and reason for the changes. It's recommended to add a brief description to provide more context for reviewers.

2. In the new YAML files, the name field under each workflow is set to Skaffold - test, which might be confusing and not descriptive enough. Consider using unique and descriptive names for each workflow.

name: <Descriptive Workflow Name>

3. Make sure that you've tested these changes and ensure that they work as expected on GitHub Actions. If something doesn't work as expected, debug and fix the issues before merging the pull request.

4. Ensure that the new workflows are compatible with the existing CI/CD pipeline and do not introduce any breaking changes or conflicts.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of Key Changes

This pull request splits the CI pull jobs into separate GitHub workflows for better organization and more granular control. The key changes include:

1. ci.yaml file has been removed.
2. New workflow files added:
   • pull-cd-build-base-images.yaml
   • pull-ci-release-utils-images.yaml
   • pull-ci-runtime-base-images.yaml
   • pull-prod-runtime-base-images.yaml
3. Update in Justfile.
4. Removal of dockerfiles-multi-stages/tikv/Dockerfile.
5. Changes in Dockerfile paths and addition of new Dockerfiles.

Potential Problems

1. The pr description is empty, it could be helpful to add a brief description of the changes made in this pull request.

Suggestions

1. Add a brief description of the changes made in the pull request to help reviewers understand the purpose and the context of the changes.
2. Review all the new workflow files and Dockerfiles to ensure they are configured correctly and according to the desired CI/CD pipeline structure.
3. Test the new CI/CD pipeline to ensure the builds are successful, and the expected artifacts are generated correctly.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review Summary

Title: ci: split CI pull jobs

Description: (Empty)

Key Changes:

1. Deleted file .github/workflows/ci.yaml
2. Added new CI workflow files:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Updated Justfile with new build steps.
4. Removed dockerfiles-multi-stages/tikv/Dockerfile
5. Updated several Dockerfiles in the dockerfiles directory.
6. Added dockerfiles/cd/skaffold.yaml

Potential Problems:

1. No description provided for the Pull Request.
2. Some files have been deleted, which might cause issues if other parts of the project rely on them. For example, the deletion of .github/workflows/ci.yaml and dockerfiles-multi-stages/tikv/Dockerfile.

Suggestions:

1. Add a description to the Pull Request explaining the changes made and the motivation behind them.
2. Ensure that the deleted files are not being used elsewhere in the project, or update any references to them.
3. Test the new CI workflows to ensure they are functioning correctly.
4. Verify that the new Dockerfiles and Skaffold configurations work as intended.

Overall, this Pull Request seems to split the CI jobs into separate workflow files and updates various Dockerfiles. However, a proper description and testing should be done to ensure the changes work as intended.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary

This pull request titled ci: split CI pull jobs contains the following changes:

• Deleted .github/workflows/ci.yaml file.
• Added new workflow files:
  • .github/workflows/pull-cd-build-base-images.yaml
  • .github/workflows/pull-ci-release-utils-images.yaml
  • .github/workflows/pull-ci-runtime-base-images.yaml
  • .github/workflows/pull-prod-runtime-base-images.yaml
• Updated Justfile.
• Deleted dockerfiles-multi-stages/tikv/Dockerfile.
• Renamed and updated dockerfiles/ci/release-build-base/tiflash/Dockerfile to dockerfiles/cd/pingcap/tiflash/Dockerfile.
• Added new dockerfiles/cd/skaffold.yaml.
• Added new dockerfiles/cd/tikv/tikv/Dockerfile.

Potential Problems

1. There is no description provided in the pull request, which makes it difficult to understand the context and the reason for the changes.
2. The pull request deletes the existing ci.yaml workflow file and creates multiple new workflow files. This change may affect the existing CI process if not handled carefully.
3. In the new workflow files, the name property of each workflow is set to Skaffold - test, which might be confusing. Consider updating the name property to better describe each workflow.

Suggestions

1. Provide a descriptive explanation for the changes in the pull request description. This helps reviewers understand the context and the reason for the changes.
2. Verify if splitting the existing workflow into multiple new workflows is intended and if it will not affect the existing CI process negatively.
3. Update the name property of each new workflow file to better describe the purpose of each workflow.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: ci: split CI pull jobs

Key Changes:

1. Original CI workflow file ci.yaml is deleted.
2. Four new CI workflow files are created:
   • pull-cd-build-base-images.yaml
   • pull-ci-release-utils-images.yaml
   • pull-ci-runtime-base-images.yaml
   • pull-prod-runtime-base-images.yaml
3. Update in Justfile for building images.

Potential Problems:

1. No pull request description is provided.
2. Original workflow file ci.yaml is deleted completely, which might cause issues if the new workflow files don't cover all necessary CI jobs.
3. The new workflow files are not interconnected, which might cause issues in case some jobs are dependent on others.

Fixing Suggestions:

1. Provide a clear and concise description for this pull request, explaining the changes and their purpose.
2. Check if the new workflow files cover all necessary CI jobs, and if not, consider restoring or modifying the original ci.yaml file to accommodate any missing jobs.
3. If there are any dependencies between the new workflow files, make sure to properly configure those dependencies, or consider merging the workflow files if necessary.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title

ci: split CI pull jobs

Summary

The PR aims to split the CI pull jobs, which affects the GitHub Actions workflows and Dockerfiles.

Key Changes

1. The .github/workflows/ci.yaml file is deleted.
2. New GitHub Actions workflows are created:

• .github/workflows/pull-cd-build-base-images.yaml
• .github/workflows/pull-ci-release-utils-images.yaml
• .github/workflows/pull-ci-runtime-base-images.yaml
• .github/workflows/pull-prod-runtime-base-images.yaml

3. Changes in the Justfile.
4. Deletion of dockerfiles-multi-stages/tikv/Dockerfile.
5. Creation of dockerfiles/cd/pingcap/tiflash/Dockerfile.
6. Creation of dockerfiles/cd/skaffold.yaml.
7. Creation of dockerfiles/cd/tikv/tikv/Dockerfile.
8. Deletion of dockerfiles/ci/release-build-base/tiflash/Dockerfile.

Potential Issues

1. The PR description is empty, which makes it difficult to understand the context and motivation behind the changes.
2. There are no additions or modifications to any tests, which could lead to potential regressions if not tested properly.

Suggestions

1. Update the PR description to provide more context and motivation behind the changes.
2. Ensure the changes are properly tested before merging. Add or update any relevant tests if necessary.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review Summary

Title: ci: split CI pull jobs

Description: (empty)

Key Changes:

1. Deleted .github/workflows/ci.yaml which contained various jobs for building images related to product base, CI base, and CI utils.
2. Added new workflow files for each specific job, which are:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Updated Justfile with new build steps for msb-tikv and msb-tiflash.
4. Removed dockerfiles-multi-stages/tikv/Dockerfile.
5. Added new Dockerfiles for building images in dockerfiles/cd directory.
6. Removed dockerfiles/ci/release-build-base/tiflash/Dockerfile.

Potential Problems:

1. The pull request description is empty, which makes it difficult to understand the motivation behind these changes.

Fixing Suggestions:

1. Provide a clear description for the pull request explaining the changes made and the motivation behind them.
2. Ensure that the new workflow files work correctly and maintain the required functionality from the deleted ci.yaml file.
3. Test the new Dockerfiles and build steps in the Justfile to ensure they work as expected.

### Pull Request Review Summary

**Title:** `ci: split CI pull jobs`

**Description:** _(empty)_

#### Key Changes:

1. Deleted `.github/workflows/ci.yaml` which contained various jobs for building images related to product base, CI base, and CI utils.
2. Added new workflow files for each specific job, which are:
   - `.github/workflows/pull-cd-build-base-images.yaml`
   - `.github/workflows/pull-ci-release-utils-images.yaml`
   - `.github/workflows/pull-ci-runtime-base-images.yaml`
   - `.github/workflows/pull-prod-runtime-base-images.yaml`
3. Updated `Justfile` with new build steps for `msb-tikv` and `msb-tiflash`.
4. Removed `dockerfiles-multi-stages/tikv/Dockerfile`.
5. Added new Dockerfiles for building images in `dockerfiles/cd` directory.
6. Removed `dockerfiles/ci/release-build-base/tiflash/Dockerfile`.

#### Potential Problems:

1. The pull request description is empty, which makes it difficult to understand the motivation behind these changes.

#### Fixing Suggestions:

1. Provide a clear description for the pull request explaining the changes made and the motivation behind them.
2. Ensure that the new workflow files work correctly and maintain the required functionality from the deleted `ci.yaml` file.
3. Test the new Dockerfiles and build steps in the `Justfile` to ensure they work as expected.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Summary

Title: ci: split CI pull jobs

Description: (empty)

Key Changes:

1. The original CI jobs in .github/workflows/ci.yaml have been split into multiple separate CI jobs in different files:

   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml

2. Multiple Dockerfiles have been added, modified, or deleted in the dockerfiles directory.

3. The Justfile has been updated with new build steps.

Potential Problems:

1. The original CI jobs seem to be deleted entirely, and there is no description provided for the purpose of splitting the jobs. It might be useful to have a brief explanation of why these jobs were split and how they relate to each other.

Fixing Suggestions:

1. Add a brief explanation for the purpose of splitting the CI jobs in the PR description.

2. Double-check and test the new CI jobs to ensure they cover the same functionality as the original CI jobs.

3. Ensure that the added, modified, or deleted Dockerfiles are working as expected and do not introduce any issues.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of the changes

This pull request (PR) mainly focuses on splitting the original CI jobs into separate jobs and updating the file structure accordingly. Here are the key changes:

1. Deleted .github/workflows/ci.yaml
2. Added new files for separate jobs:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Updated the Justfile with new build steps
4. Deleted dockerfiles-multi-stages/tikv/Dockerfile
5. Added new Dockerfiles:
   • dockerfiles/cd/pingcap/tiflash/Dockerfile
   • dockerfiles/cd/skaffold.yaml
   • dockerfiles/cd/tikv/tikv/Dockerfile
6. Deleted dockerfiles/ci/release-build-base/tiflash/Dockerfile

Potential problems

1. The PR description is blank, which makes it difficult for reviewers and maintainers to understand the intentions and implications of the changes.
2. The changes in the PR involve splitting the CI jobs, which might affect the existing workflow and introduce potential issues in running the jobs.

Suggestions for fixing

1. Add a detailed description to the PR explaining the reasoning behind the changes, the advantages of splitting the CI jobs, and any potential issues that might arise.
2. Thoroughly test the new CI jobs and ensure that they work correctly and do not interfere with each other.
3. If necessary, update the project documentation to reflect the changes made in this PR, as well as any potential implications and required adjustments in the development workflow.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary:

This pull request is titled ci: split CI pull jobs. It focuses on splitting the CI jobs into different workflows for better organization and separation of concerns.

Key changes include:

1. Deleted .github/workflows/ci.yaml file.
2. Added new workflow files:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Updated few Docker files and Skaffold configuration files.

Potential problems:

1. There is no PR description provided, making it difficult to understand the context and motivation behind the changes.

Suggestions:

1. Provide a clear PR description explaining the motivation and benefits of splitting the CI jobs into separate workflows.
2. Ensure that the new workflows are properly integrated and functioning as expected in the CI/CD pipeline.

Overall, the PR needs a clear description and proper testing to ensure the changes work as intended.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review Summary

Title: ci: split CI pull jobs

Description: (empty)

Key Changes:

• Deleted .github/workflows/ci.yaml
• Added .github/workflows/pull-cd-build-base-images.yaml
• Added .github/workflows/pull-ci-release-utils-images.yaml
• Added .github/workflows/pull-ci-runtime-base-images.yaml
• Added .github/workflows/pull-prod-runtime-base-images.yaml
• Modified Justfile
• Deleted dockerfiles-multi-stages/tikv/Dockerfile
• Added dockerfiles/cd/pingcap/tiflash/Dockerfile
• Added dockerfiles/cd/skaffold.yaml
• Added dockerfiles/cd/tikv/tikv/Dockerfile
• Deleted dockerfiles/ci/release-build-base/tiflash/Dockerfile

Potential Problems and Suggestions:

1. Empty PR description: It is recommended to provide a brief description of the changes and the motivation behind them.

2. New workflow files: It seems that the CI workflow has been split into multiple smaller workflows. Make sure that all the necessary dependencies and configurations are properly set up in these new files.

3. Dockerfile changes: Ensure that the modified Dockerfiles are tested and working as expected with the new configurations.

4. File deletions: Double-check if the deleted files are no longer needed in the project.

5. Update PR description: To help the reviewer and future contributors, please update the PR description with a brief summary of the changes and their purpose.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title:

ci: split CI pull jobs

Summary:

This pull request aims to split the CI jobs in the GitHub Actions workflow. The key changes are the creation of new workflow files and the deletion of the existing ci.yaml file.

Changes:

• Deleted the .github/workflows/ci.yaml file.
• Added new workflow files:
  • .github/workflows/pull-cd-build-base-images.yaml
  • .github/workflows/pull-ci-release-utils-images.yaml
  • .github/workflows/pull-ci-runtime-base-images.yaml
  • .github/workflows/pull-prod-runtime-base-images.yaml
• Modified Justfile and several Dockerfiles.

Potential issues:

1. The PR description is empty, which makes it harder to understand the context and motivation behind the changes. Providing a detailed explanation of the changes and their purpose would be helpful.

2. The new workflow files have a lot of repeated code, which could be refactored to make the code more maintainable and easier to understand.

Suggestions:

1. Add a description to the PR explaining the motivation behind the changes and provide some context for reviewers.

2. Refactor the new workflow files to reduce repetition and improve maintainability. You could use GitHub Actions composite run steps to reuse common steps across multiple jobs or workflows.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: ci: split CI pull jobs

Description: empty

Key Changes

1. The original .github/workflows/ci.yaml file has been deleted.
2. Four new GitHub workflows have been added:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Some Dockerfile changes have been made, including deletions, additions, and modifications.
4. A new dockerfiles/cd/skaffold.yaml file has been added.
5. Modifications have been made to the Justfile.

Potential Problems

1. The PR description is empty, which does not provide any context about the changes made and the reason behind them.
2. There might be potential issues with the newly added GitHub workflows, such as incorrect paths, missing dependencies, or permission issues.

Fixing Suggestions

1. Provide a detailed description in the PR, explaining the purpose of the changes and their expected outcome.
2. Thoroughly test the new GitHub workflows to ensure they work as expected and address any issues that may arise during testing.
3. Review the changes made to the Dockerfiles and Justfile to ensure they are correct and follow best practices.
4. Add comments to the new files, such as the skaffold.yaml and the new GitHub workflows, to provide context and improve readability.

Please let me know if you need further assistance or have any questions.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: ci: split CI pull jobs

Description: empty

Key Changes:

1. The original .github/workflows/ci.yaml has been deleted.
2. Four new GitHub workflow files have been created:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Several Dockerfile updates and additions in dockerfiles directory.

Potential Problems:

1. The PR description is empty, which makes it difficult for the reviewers to understand the context and the purpose of the changes.

Fixing suggestions:

1. Add a detailed PR description explaining the purpose of splitting CI jobs and the expected benefits.
2. Make sure the new workflow files are properly configured and running as expected, check for any errors or inconsistencies.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: ci: split CI pull jobs

Description:

(Empty)

Summary of Key Changes:

• Deleted .github/workflows/ci.yaml
• Added .github/workflows/pull-cd-build-base-images.yaml
• Added .github/workflows/pull-ci-release-utils-images.yaml
• Added .github/workflows/pull-ci-runtime-base-images.yaml
• Added .github/workflows/pull-prod-runtime-base-images.yaml
• Updated Justfile
• Deleted dockerfiles-multi-stages/tikv/Dockerfile
• Added dockerfiles/cd/pingcap/tiflash/Dockerfile
• Added dockerfiles/cd/skaffold.yaml
• Added dockerfiles/cd/tikv/tikv/Dockerfile
• Deleted dockerfiles/ci/release-build-base/tiflash/Dockerfile

Potential Problems:

1. The PR description is empty. It is important to provide a description for the changes made for better understanding and tracking.
2. The .github/workflows/ci.yaml file has been deleted, which might affect other CI/CD processes in the repository.
3. Some files have been deleted, which might cause issues if they are required in other parts of the project.

Fixing Suggestions:

1. Provide a description for the changes made in this PR to clarify the purpose and any additional context.
2. Ensure that deleting the .github/workflows/ci.yaml file will not cause any issues with the CI/CD processes. Consider keeping the file and updating it with the necessary changes, if required.
3. Double-check if the deleted files are not required in other parts of the project. If they are, consider keeping them and making the necessary updates instead of deleting them.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review Summary

Title: ci: split CI pull jobs

Description: (empty)

Key Changes:

1. Deleted .github/workflows/ci.yaml file.
2. Added new workflow files:
   • .github/workflows/pull-cd-build-base-images.yaml
   • .github/workflows/pull-ci-release-utils-images.yaml
   • .github/workflows/pull-ci-runtime-base-images.yaml
   • .github/workflows/pull-prod-runtime-base-images.yaml
3. Updated Justfile with new build steps.
4. Removed dockerfiles-multi-stages/tikv/Dockerfile.
5. Added new Dockerfiles for building images:
   • dockerfiles/cd/pingcap/tiflash/Dockerfile
   • dockerfiles/cd/skaffold.yaml
   • dockerfiles/cd/tikv/tikv/Dockerfile

Potential Problems:

1. No description is provided in the PR.
2. The PR adds new GitHub workflows, but it's not clear if they have been tested or if they are working as expected.
3. Some changes in Dockerfiles may impact the build process.

Fixing Suggestions:

1. Add a clear description to the PR explaining the purpose of the changes and what the new workflows are intended to do.
2. Test the new GitHub workflows to ensure they are working correctly and fix any issues.
3. Review the changes in Dockerfiles and ensure they are compatible with the intended build process.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of Changes

The PR is titled ci: split CI pull jobs. It removes a single CI workflow file and replaces it with four separate CI workflow files. The new files are:

1. pull-cd-build-base-images.yaml
2. pull-ci-release-utils-images.yaml
3. pull-ci-runtime-base-images.yaml
4. pull-prod-runtime-base-images.yaml

Here are the key changes:

• The original ci.yaml file is deleted.
• The new workflow files are added for different CI jobs.
• The new workflow files have their own concurrency groups, which allows for more efficient parallelization during the CI process.
• The new workflow files have updated paths to their respective Dockerfiles.
• The Justfile has been updated with new build commands.

Potential Problems

• With the original ci.yaml file removed, if there are any dependencies or triggers in other parts of the codebase that rely on this file, they will break.
• The new workflow files may have different triggers, which could potentially lead to unexpected behavior in the CI pipeline.
• The changes in the Justfile could lead to changes in the build process.

Suggestions

• Ensure that there are no dependencies on the original ci.yaml file in other parts of the codebase.
• Test the new workflow files thoroughly to ensure that they work as expected and do not introduce any unintended behavior.
• Review the changes in the Justfile and ensure that they are correct and do not introduce any unintended side effects in the build process.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment