-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tidb-operator): add package config for operator v2 #530
Conversation
add flag `--target` and `--skip-unused-stages` when `target` given in package config. Signed-off-by: wuhuizuo <[email protected]>
publish 2 images. owner can request to add new images in future. Signed-off-by: wuhuizuo <[email protected]>
Signed-off-by: wuhuizuo <[email protected]>
Based on the pull request title and diff, it seems that the changes involve adding a package config for operator v2. Specifically, the changes include updating the One potential problem I see is that the pull request description is empty, which makes it difficult for reviewers to understand the context and purpose of the changes. It would be helpful if the author provided some background information and reasoning for the changes. As for fixing suggestions, the author may want to consider adding more information to the pull request description, including why these changes are necessary and how they improve the project. Additionally, they may want to double-check that the changes do not introduce any new issues or conflicts with existing code. Finally, they may want to ensure that the changes adhere to any relevant project guidelines and best practices. |
/cc @csuzhangxc PTAL |
@csuzhangxc: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve it is approved by owner of |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csuzhangxc, wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Background
TiDB-operator owner want publish artifacts for the refactoring tidb-operator, the version start from v2.0.0.